Skip to content

Add "exportKind: type" when needed with TS#11157

Merged
nicolo-ribaudo merged 2 commits intobabel:feat-7.9.0/ts-import-typefrom
nicolo-ribaudo:export-type-ts-part-3
Feb 26, 2020
Merged

Add "exportKind: type" when needed with TS#11157
nicolo-ribaudo merged 2 commits intobabel:feat-7.9.0/ts-import-typefrom
nicolo-ribaudo:export-type-ts-part-3

Conversation

@nicolo-ribaudo
Copy link
Copy Markdown
Member

Q                       A
Fixed Issues? Fixes #11132
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? 👍
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

These are type-only exports:

  • interface X {}
  • type A = 2
  • declare var x;
  • declare function y(): T

These are values:

  • enum E {}
  • namespace N {}

nicolo-ribaudo and others added 2 commits February 19, 2020 20:39
Co-authored-by: Henry Zhu <smiley.we@gmail.com>
Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
Co-authored-by: Siddhant N Trivedi <sidntrivedi012@gmail.com>
@nicolo-ribaudo nicolo-ribaudo added the PR: New Feature 🚀 A type of pull request used for our changelog categories label Feb 19, 2020
@JLHwung JLHwung added this to the v7.9.0 milestone Feb 19, 2020
@nicolo-ribaudo nicolo-ribaudo requested review from existentialism and kaicataldo and removed request for existentialism February 22, 2020 12:59
@nicolo-ribaudo nicolo-ribaudo merged commit d9b4e19 into babel:feat-7.9.0/ts-import-type Feb 26, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the export-type-ts-part-3 branch February 26, 2020 00:27
nicolo-ribaudo added a commit that referenced this pull request Feb 26, 2020
* Add "exportKind: type" to TS type export declratation

Co-authored-by: Henry Zhu <smiley.we@gmail.com>
Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
Co-authored-by: Siddhant N Trivedi <sidntrivedi012@gmail.com>

* Add test to @babel/generator

Co-authored-by: Henry Zhu <hi@henryzoo.com>
Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
Co-authored-by: Siddhant N Trivedi <sidntrivedi012@gmail.com>
nicolo-ribaudo added a commit that referenced this pull request Mar 2, 2020
* Add "exportKind: type" to TS type export declratation

Co-authored-by: Henry Zhu <smiley.we@gmail.com>
Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
Co-authored-by: Siddhant N Trivedi <sidntrivedi012@gmail.com>

* Add test to @babel/generator

Co-authored-by: Henry Zhu <hi@henryzoo.com>
Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
Co-authored-by: Siddhant N Trivedi <sidntrivedi012@gmail.com>
nicolo-ribaudo added a commit that referenced this pull request Mar 16, 2020
* Add support for type only imports in TS (#11053)
* Implement "export type {}" (#11122)
* Add "exportKind: type" when needed with TS (#11157)
* Add `onlyRemoveTypeImports` option to `transform-typescript` (#11173)
* Add onlyRemoveTypeImports to preset-typescript (#11179)

Co-authored-by: Brian Ng <bng412@gmail.com>
Co-authored-by: Raja Sekar <rajasekarm.dev@gmail.com>
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
Co-authored-by: Kai Cataldo <kai@kaicataldo.com>
Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
Co-authored-by: Henry Zhu <smiley.we@gmail.com>
Co-authored-by: Siddhant N Trivedi <sidntrivedi012@gmail.com>
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 27, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: New Feature 🚀 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants