Skip to content

Import type for TS#11053

Merged
nicolo-ribaudo merged 4 commits intofeat-7.9.0/ts-import-typefrom
import-type
Jan 24, 2020
Merged

Import type for TS#11053
nicolo-ribaudo merged 4 commits intofeat-7.9.0/ts-import-typefrom
import-type

Conversation

@hzoo
Copy link
Copy Markdown
Member

@hzoo hzoo commented Jan 23, 2020 •
edited by jridgewell
Loading

Q                       A
Fixed Issues? fixes #10981
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? Yea
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Implemented for import type, still need to implement export

hzoo and others added 2 commits January 23, 2020 15:01
@hzoo @existentialism
@rajasekarm @nicolo-ribaudo
Add parser support for type only imports in TS
4db2fbe 
Co-authored-by: Brian Ng <bng412@gmail.com>
Co-authored-by: Raja Sekar <rajasekarm.dev@gmail.com>
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
Co-authored-by: Kai Cataldo <kai@kaicataldo.com>
@hzoo @existentialism
@rajasekarm @nicolo-ribaudo
Add transform and printer test for type only imports in TS
f3a6fa3 
Co-authored-by: Brian Ng <bng412@gmail.com>
Co-authored-by: Raja Sekar <rajasekarm.dev@gmail.com>
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
Co-authored-by: Kai Cataldo <kai@kaicataldo.com>
@hzoo hzoo added PR: New Feature 🚀 A type of pull request used for our changelog categories pkg: parser area: typescript labels Jan 23, 2020
@hzoo hzoo added this to the v7.9.0 milestone Jan 23, 2020
existentialism
existentialism reviewed Jan 23, 2020
View reviewed changes
nicolo-ribaudo
nicolo-ribaudo reviewed Jan 23, 2020
View reviewed changes
@nicolo-ribaudo nicolo-ribaudo changed the base branch from master to feat-7.9.0/ts-import-type January 24, 2020 21:25
@nicolo-ribaudo
Copy link
Copy Markdown
Member

nicolo-ribaudo commented Jan 24, 2020

I have changed the base branch to feat-7.9.0/ts-import-type so that we can merge it there and work on export type and the transform plugin option.

@nicolo-ribaudo nicolo-ribaudo merged commit a69a56f into feat-7.9.0/ts-import-type Jan 24, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the import-type branch January 24, 2020 21:50
@nicolo-ribaudo
Copy link
Copy Markdown
Member

nicolo-ribaudo commented Jan 24, 2020

⚠️ This PR is not merged to master yet

JLHwung pushed a commit to JLHwung/babel that referenced this pull request Feb 10, 2020
@hzoo @existentialism
@nicolo-ribaudo @JLHwung
Import type for TS (babel#11053)
dccfa40 
* Add parser support for type only imports in TS

Co-authored-by: Brian Ng <bng412@gmail.com>
Co-authored-by: Raja Sekar <rajasekarm.dev@gmail.com>
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
Co-authored-by: Kai Cataldo <kai@kaicataldo.com>

* Add transform and printer test for type only imports in TS

Co-authored-by: Brian Ng <bng412@gmail.com>
Co-authored-by: Raja Sekar <rajasekarm.dev@gmail.com>
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
Co-authored-by: Kai Cataldo <kai@kaicataldo.com>

* Update packages/babel-parser/src/plugins/typescript/index.js

* Fix flow

Co-authored-by: Brian Ng <bng412@gmail.com>
Co-authored-by: Raja Sekar <rajasekar.murugan@omio.com>
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
Co-authored-by: Kai Cataldo <kai@kaicataldo.com>
nicolo-ribaudo added a commit that referenced this pull request Feb 10, 2020
@hzoo @existentialism @nicolo-ribaudo
Import type for TS (#11053)
465c123 
* Add parser support for type only imports in TS

Co-authored-by: Brian Ng <bng412@gmail.com>
Co-authored-by: Raja Sekar <rajasekarm.dev@gmail.com>
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
Co-authored-by: Kai Cataldo <kai@kaicataldo.com>

* Add transform and printer test for type only imports in TS

Co-authored-by: Brian Ng <bng412@gmail.com>
Co-authored-by: Raja Sekar <rajasekarm.dev@gmail.com>
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
Co-authored-by: Kai Cataldo <kai@kaicataldo.com>

* Update packages/babel-parser/src/plugins/typescript/index.js

* Fix flow

Co-authored-by: Brian Ng <bng412@gmail.com>
Co-authored-by: Raja Sekar <rajasekar.murugan@omio.com>
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
Co-authored-by: Kai Cataldo <kai@kaicataldo.com>
@bramkragten bramkragten mentioned this pull request Feb 22, 2020
Merged
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Feb 26, 2020
Merged
nicolo-ribaudo added a commit that referenced this pull request Feb 26, 2020
@hzoo @existentialism @nicolo-ribaudo
Import type for TS (#11053)
ed2af92 
* Add parser support for type only imports in TS

Co-authored-by: Brian Ng <bng412@gmail.com>
Co-authored-by: Raja Sekar <rajasekarm.dev@gmail.com>
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
Co-authored-by: Kai Cataldo <kai@kaicataldo.com>

* Add transform and printer test for type only imports in TS

Co-authored-by: Brian Ng <bng412@gmail.com>
Co-authored-by: Raja Sekar <rajasekarm.dev@gmail.com>
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
Co-authored-by: Kai Cataldo <kai@kaicataldo.com>

* Update packages/babel-parser/src/plugins/typescript/index.js

* Fix flow

Co-authored-by: Brian Ng <bng412@gmail.com>
Co-authored-by: Raja Sekar <rajasekar.murugan@omio.com>
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
Co-authored-by: Kai Cataldo <kai@kaicataldo.com>
nicolo-ribaudo added a commit that referenced this pull request Mar 2, 2020
@hzoo @existentialism @nicolo-ribaudo
Import type for TS (#11053)
a1a889b 
* Add parser support for type only imports in TS

Co-authored-by: Brian Ng <bng412@gmail.com>
Co-authored-by: Raja Sekar <rajasekarm.dev@gmail.com>
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
Co-authored-by: Kai Cataldo <kai@kaicataldo.com>

* Add transform and printer test for type only imports in TS

Co-authored-by: Brian Ng <bng412@gmail.com>
Co-authored-by: Raja Sekar <rajasekarm.dev@gmail.com>
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
Co-authored-by: Kai Cataldo <kai@kaicataldo.com>

* Update packages/babel-parser/src/plugins/typescript/index.js

* Fix flow

Co-authored-by: Brian Ng <bng412@gmail.com>
Co-authored-by: Raja Sekar <rajasekar.murugan@omio.com>
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
Co-authored-by: Kai Cataldo <kai@kaicataldo.com>
nicolo-ribaudo added a commit that referenced this pull request Mar 16, 2020
@nicolo-ribaudo @existentialism
@rajasekarm @JLHwung @hzoo @sidntrivedi
Add import type and export type support to TypeScript (#11171)
740260b 
* Add support for type only imports in TS (#11053)
* Implement "export type {}" (#11122)
* Add "exportKind: type" when needed with TS (#11157)
* Add `onlyRemoveTypeImports` option to `transform-typescript` (#11173)
* Add onlyRemoveTypeImports to preset-typescript (#11179)

Co-authored-by: Brian Ng <bng412@gmail.com>
Co-authored-by: Raja Sekar <rajasekarm.dev@gmail.com>
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
Co-authored-by: Kai Cataldo <kai@kaicataldo.com>
Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
Co-authored-by: Henry Zhu <smiley.we@gmail.com>
Co-authored-by: Siddhant N Trivedi <sidntrivedi012@gmail.com>
@hzoo hzoo mentioned this pull request Mar 20, 2020
Closed
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 25, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@existentialism existentialism existentialism approved these changes

@jridgewell jridgewell jridgewell approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees

No one assigned

Labels

area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: New Feature 🚀 A type of pull request used for our changelog categories

Projects

None yet

Milestone

v7.9.0

Development

Successfully merging this pull request may close these issues.

4 participants

@hzoo @nicolo-ribaudo @existentialism @jridgewell