Implement UI-based Strict Confirmation (Following Terminal Prompt)#89
Merged
Implement UI-based Strict Confirmation (Following Terminal Prompt)#89
Conversation
Merged
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Mar 26, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [babarot/gomi](https://github.com/babarot/gomi) | minor | `v1.5.1` -> `v1.6.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>babarot/gomi (babarot/gomi)</summary> ### [`v1.6.0`](https://github.com/babarot/gomi/blob/HEAD/CHANGELOG.md#v160---2025-02-26) [Compare Source](babarot/gomi@v1.5.1...v1.6.0) ##### New Features - Add `--prune` option for trash management by [@​babarot](https://github.com/babarot) in babarot/gomi#88 - Implement UI-based Strict Confirmation (Following Terminal Prompt) by [@​babarot](https://github.com/babarot) in babarot/gomi#89 - Add Image Preview in Detail View by [@​babarot](https://github.com/babarot) in babarot/gomi#92 ##### Refactorings - Add tests by [@​babarot](https://github.com/babarot) in babarot/gomi#86 - Add immediate renderer instead of using immediately flag by [@​babarot](https://github.com/babarot) in babarot/gomi#87 ##### Website Updates - Add Website Carousel and Reorganize Project Documentation by [@​babarot](https://github.com/babarot) in babarot/gomi#90 - Tweak site designs, animations and layouts by [@​babarot](https://github.com/babarot) in babarot/gomi#91 ##### Others - Add strict YES validation to confirm prompt by [@​babarot](https://github.com/babarot) in babarot/gomi#85 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMTMuNSIsInVwZGF0ZWRJblZlciI6IjM5LjIxMy41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
This PR enhances the confirmation dialog in the UI by introducing two distinct confirmation modes:
Key Implementation Details:
confirmationstruct toViewStateto track confirmation stateConfirmStatetype with two modes:ConfirmStateYesNoandConfirmStateTypeYESWHY
This implementation extends the previous work in PR #85, bringing the strict confirmation mechanism from the terminal prompt to the restore UI.
The motivation remains the same: preventing accidental deletions by:
By implementing this in the UI layer, we provide a consistent and safe deletion experience across different interaction modes.