Skip to content

Add immediate renderer instead of using immediately flag#87

Merged
babarot merged 1 commit intomainfrom
babarot/confirm-refactoring
Feb 24, 2025
Merged

Add immediate renderer instead of using immediately flag#87
babarot merged 1 commit intomainfrom
babarot/confirm-refactoring

Conversation

@babarot
Copy link
Copy Markdown
Owner

@babarot babarot commented Feb 24, 2025

WHAT

This PR enhances the confirmation component by introducing a new ImmediateInput rendering mode, which allows immediate confirmation upon a single key press without requiring the Enter key. It replaces the previous Immediately boolean flag for better flexibility and clarity.

  • Introduced ImmediateInput rendering mode
    • Allows immediate confirmation when a user presses Y or N.
    • Eliminates the need to press Enter after selection.
  • Refactored confirmation logic
    • Replaced the Immediately boolean flag with the ImmediateInput enum.
    • Added a dedicated immediateRenderer for handling immediate input.
    • Improved input handling by checking the first character of the accepted/denied decision text.

WHY

  • Makes the rendering intent more explicit
  • Ensures consistency with other rendering modes
  • Improves future extensibility

@babarot babarot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, issues, etc. label Feb 24, 2025
@babarot babarot merged commit cb4a3ff into main Feb 24, 2025
5 checks passed
@babarot babarot deleted the babarot/confirm-refactoring branch February 24, 2025 04:47
@github-actions github-actions bot mentioned this pull request Feb 24, 2025
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Mar 26, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [babarot/gomi](https://github.com/babarot/gomi) | minor | `v1.5.1` -> `v1.6.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>babarot/gomi (babarot/gomi)</summary>

### [`v1.6.0`](https://github.com/babarot/gomi/blob/HEAD/CHANGELOG.md#v160---2025-02-26)

[Compare Source](babarot/gomi@v1.5.1...v1.6.0)

##### New Features

-   Add `--prune` option for trash management by [@&#8203;babarot](https://github.com/babarot) in babarot/gomi#88
-   Implement UI-based Strict Confirmation (Following Terminal Prompt) by [@&#8203;babarot](https://github.com/babarot) in babarot/gomi#89
-   Add Image Preview in Detail View by [@&#8203;babarot](https://github.com/babarot) in babarot/gomi#92

##### Refactorings

-   Add tests  by [@&#8203;babarot](https://github.com/babarot) in babarot/gomi#86
-   Add immediate renderer instead of using immediately flag by [@&#8203;babarot](https://github.com/babarot) in babarot/gomi#87

##### Website Updates

-   Add Website Carousel and Reorganize Project Documentation by [@&#8203;babarot](https://github.com/babarot) in babarot/gomi#90
-   Tweak site designs, animations and layouts by [@&#8203;babarot](https://github.com/babarot) in babarot/gomi#91

##### Others

-   Add strict YES validation to confirm prompt by [@&#8203;babarot](https://github.com/babarot) in babarot/gomi#85

</details>

---

### Configuration

πŸ“… **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

β™» **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

πŸ”• **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMTMuNSIsInVwZGF0ZWRJblZlciI6IjM5LjIxMy41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Categorizes issue or PR as related to cleaning up code, issues, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant