Merged
Conversation
Contributor
|
Well, that's an unfortunate breaking change. I guess it is still in the 0.x range, haha. Thanks for bumping axoasset to 2.0.0; that feels right given this change. |
Contributor
|
Reading the PR:
I wonder if axoasset wants to be doing this, to try to preserve OS certificate store support? |
Contributor
|
Additional context on compatibility concerns here: astral-sh/uv#17427 |
Contributor
|
Having looked it over a few times it seems like the fact that you need to pass a reqwest::Client to axoasset, and the new relevant API is on ClientBuilder means this is out of its hands, so I don't think we need to add anything. |
Contributor
Author
|
I'm surprised no one complained about this in uv before, but we weren't using the same client before: axodotdev/axoupdater#334 |
5a77357 to
ba0b591
Compare
reqwest 0.13 switched from native-tls by default to rustls by default, and also switched to rustls-platform-verifier (seanmonstar/reqwest#2891). This means that two features that axoasset currently uses or exposes, rustls-tls-native-roots and rustls-tls-webpki-roots, don't exist anymore. While axoasset is technically compatible with reqwest 0.13, cargo blocks the update due to the missing features: ``` error: failed to select a version for `reqwest`. ... required by package `axoasset v1.5.0 (/home/konsti/projects/axoasset)` versions that meet the requirements `>=0.13.0` are: 0.13.2, 0.13.1, 0.13.0 package `axoasset` depends on `reqwest` with feature `rustls-tls-webpki-roots` but `reqwest` does not have that feature. failed to select a version for `reqwest` which could resolve this conflict ``` I'm not aware of a way to expose feature conditionally depending on the package version with Cargo. This PR proposes to bump reqwest to a minimum of 0.13. I'm not sure if to consider that a breaking change, as we do update inside a compatible range, but if you have `axoasset::AxoClient::with_reqwest(reqwest::Client::new())` in your code and use reqwest 0.12, it will cause an error. Cargo doesn't see that reqwest as a dependency is part of the public API and needs to match the caller's version.
ba0b591 to
a26e773
Compare
Gankra
approved these changes
Feb 12, 2026
This was referenced Feb 18, 2026
mistydemeo
added a commit
that referenced
this pull request
Feb 20, 2026
An oversight in #395 meant that we removed the TLS feature we were using before without adding a replacement, and with `default-features = false` still enabled. Consequently, we accidentally built reqwest with no TLS support at all
mistydemeo
added a commit
that referenced
this pull request
Feb 20, 2026
An oversight in #395 meant that we removed the TLS feature we were using before without adding a replacement, and with `default-features = false` still enabled. Consequently, we accidentally built reqwest with no TLS support at all
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reqwest 0.13 switched from native-tls by default to rustls by default, and also switched to rustls-platform-verifier (seanmonstar/reqwest#2891). This means that two features that axoasset currently uses or exposes, rustls-tls-native-roots and rustls-tls-webpki-roots, don't exist anymore. While axoasset is technically compatible with reqwest 0.13, cargo blocks the update due to the missing features:
I'm not aware of a way to expose feature conditionally depending on the package version with Cargo. This PR proposes to bump reqwest to a minimum of 0.13.
I'm not sure if to consider that a breaking change, as we do update inside a compatible range, but if you have
axoasset::AxoClient::with_reqwest(reqwest::Client::new())in your code and use reqwest 0.12, it will cause an error. Cargo doesn't see that reqwest as a dependency is part of the public API and needs to match the caller's version.