Merged
Conversation
This allows setting a pre-configured reqwest Client with alternative settings, such as TLS certs.
a9bf2e0 to
3f05339
Compare
Gankra
approved these changes
Feb 12, 2026
| tokens: AuthorizationTokens::default(), | ||
| always_update: false, | ||
| modify_path: true, | ||
| client: reqwest::Client::new(), |
Contributor
There was a problem hiding this comment.
Is it a problem for us to make one by default and then immediately throw it out when they set the client? Genuinely unsure. Probably fine?
Contributor
Author
There was a problem hiding this comment.
It can be a performance concern, iirc loading certs on mac is slow, I'm sure how to do this better without bigger changes (which may be required, but I'd need guidance on what we want to change)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows setting a pre-configured reqwest Client with alternative settings, such as TLS certs.