Remove unused dsql.region system property from Flyway build#6
Closed
danielfrankcom wants to merge 1 commit into
Closed
Remove unused dsql.region system property from Flyway build#6danielfrankcom wants to merge 1 commit into
danielfrankcom wants to merge 1 commit into
Conversation
Contributor
Author
|
Removing since this was moved to the github.com/awslabs/aurora-dsql-tools repo |
danielfrankcom
added a commit
to awslabs/aurora-dsql-tools
that referenced
this pull request
Jan 29, 2026
Removes the unused `dsql.region` system property from the Flyway adapter's Gradle build configuration. The property was being set from `AWS_REGION` but never read anywhere in the codebase. Only `dsql.cluster.endpoint` is actually used by the integration tests. Originally created as awslabs/aurora-dsql-orms#6 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
amaksimo
added a commit
that referenced
this pull request
Apr 27, 2026
- Add back examples in migrate help text (pkale comment #1) - Restructure stderr/exitCode logic: always print stderr for diagnostics, gate failure on exitCode in both handleMigrate and handleTransform (pkale comments #2, #3, #4) - Add CLI integration tests for unfixable SQL (DROP CONSTRAINT), fixable SQL (FK + index), and prisma migrate diff pipe workflow (pkale comment #6) - Remove VARCHAR(30) assertion from workflow test (pkale comment #7) - Remove false claim about prebuilt binaries in README
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the unused
dsql.regionsystem property from the Flyway adapter's Gradle build configuration.The property was being set from
AWS_REGIONbut never read anywhere in the codebase. Onlydsql.cluster.endpointis actually used by the integration tests.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.