Merged
Conversation
kaukabrizvi
approved these changes
Mar 26, 2026
dougch
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Update the AWS-LC version used by nix in the CI
Why
PR #5772 changed the ML-DSA feature probe to detect a recently added API in AWS-LC. However,
flake.lockis pinned to a specific aws-lc version, which predates the new API and caused the ML-DSA feature flag to be false. We may consider adding a CI check to ensure the AWS-LC version used by the CI is relatively up-to-date.How
Run
nix flake updatelocally and then commit the changes toflake.lock.Callouts
flake.nixtakes a dependency on Corretto21, which caused a nix error due togradle-7.6.6. Based on NixOS/nixpkgs#459071, it looks like they don't plan to fix it. As suggested in the error output, we can addgradle-7.6.6as an insecure package to work around this issue. Once corretto25 is put into nixpkgs, we can bump it.Testing
All the CodeBuild jobs succeeded after I made these changes on PR #5772.
Related
3 CodeBuild jobs (GeneralBatch, Valgrind, and AddressSanitizer) rely on pre-built Docker containers. I've rebuilt the ubuntu22 and 24 images and updated the containers used in the CI. #5790
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.