Corretto{11,17,21}: update to latest release & build with Gradle8#459071
Merged
thiagokokada merged 3 commits intoNixOS:masterfrom Dec 18, 2025
Merged
Corretto{11,17,21}: update to latest release & build with Gradle8#459071thiagokokada merged 3 commits intoNixOS:masterfrom
thiagokokada merged 3 commits intoNixOS:masterfrom
Conversation
Gradle7 is phased out in nixpkgs but corretto <= 21 does not support Gradle8. See corretto/corretto-21#114 (comment). Hence, ./corretto21-gradle8.patch is added. This patch is loosely based on corretto/corretto-jdk#135.
Gradle7 is phased out in nixpkgs but corretto <= 21 does not support Gradle8. See corretto/corretto-21#114 (comment). Hence, ./corretto17-gradle8.patch is added. This patch is loosely based on corretto/corretto-jdk#135.
Gradle7 is phased out in nixpkgs but corretto <= 21 does not support Gradle8. See corretto/corretto-21#114 (comment). Hence, ./corretto11-gradle8.patch is added. This patch is loosely based on corretto/corretto-jdk#135.
45 tasks
Contributor
Author
|
@emilazy Could you have a look here, please? (You reviewed my previous work on Corretto.) |
Contributor
Author
|
@Artturin Do you mind having a look? You reviewed some of my previous work for corretto, too. |
Contributor
Author
|
@thiagokokada Could you have a look here, please? (You reviewed my previous work on Corretto.) |
thiagokokada
approved these changes
Dec 18, 2025
Contributor
Author
Cool, thanks! I don't like this neither but I felt it was acceptable since we rather quickly remove old(er) Java versions so these patches will fade out just naturally. Thanks for merging! |
13 tasks
This was referenced Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates corretto{11,17,21} to their respective latest versions. Currently, corretto builds fail because Gradle7 is EOL'ed and not supported in nixpkgs anymore. Thus, this PR also converts corretto builds to Gradle8.
Upstream does not plan to support Gradle8 for corretto <=21. I have created patches for each corretto version that allow to build with Gradle8. Unfortunately, the patches differ so we now have 3 of them. The patches are based on the changes in corretto/corretto-jdk#135 (actual commit) but did not apply cleanly. I have manually fixed remaining issues and used only the minimal diff (of the original commit) for my patches. The actual diff to review is 3x the 10 similar lines for each corretto version. The 990+ lines in the diff stem from the patches.
I also tried to
corretto25: init at 25.0.1.9.1but that build failed and I haven't yet looked into it. I decided to keep this PR smaller for now.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.