ci: fix install_awslc_fips script#5790
Merged
CarolYeh910 merged 2 commits intoaws:mainfrom Mar 23, 2026
Merged
Conversation
kaukabrizvi
approved these changes
Mar 20, 2026
dougch
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Fix the error I ran into when rebuilding the CI Docker images
Why
The
GH_RELEASE_URLis subject to pagination (defaultper_pagevalue is 30). AWS-LC-FIPS-2.x releases are truncated in the output, causingAWSLC_BRANCHto be null and failing to build the Docker containers.How
Since
awslc-fips-2.xis no longer updated, I created a separate URL for the latest release of this major version (v2.0.17). We still useGH_RELEASE_URLforawslc_fips_2024asawslc-fips-3.xis the current major version.Testing
I ran the above command locally and confirmed that
AWS-LC-FIPS-2.0.17was built successfully. Same forinstall_awslc_fips_2024.sh.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.