Document no-op functions and flags in AWS-LC#1473
Merged
samuel40791765 merged 5 commits intoaws:mainfrom Apr 12, 2024
Merged
Conversation
e285db5 to
a436cec
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1473 +/- ##
==========================================
+ Coverage 77.01% 77.19% +0.17%
==========================================
Files 426 426
Lines 71738 71449 -289
==========================================
- Hits 55252 55157 -95
+ Misses 16486 16292 -194 ☔ View full report in Codecov by Sentry. |
justsmth
reviewed
Mar 7, 2024
Contributor
justsmth
left a comment
There was a problem hiding this comment.
Should we use our OPENSSL_DEPRECATED macro for many of these function declarations?
Contributor
Author
Good point, this was brought up as something to do, but I hadn't realized we could do it along with this PR. |
fceb872 to
020fb7a
Compare
justsmth
previously approved these changes
Mar 21, 2024
020fb7a to
b78680d
Compare
justsmth
previously approved these changes
Apr 4, 2024
andrewhop
reviewed
Apr 9, 2024
9ef968a to
ad8d97b
Compare
ad8d97b to
5fae381
Compare
andrewhop
approved these changes
Apr 12, 2024
justinwsmith
approved these changes
Apr 12, 2024
justsmth
approved these changes
Apr 12, 2024
samuel40791765
added a commit
that referenced
this pull request
Apr 26, 2024
This finalizes the changes for the previous two documentation PRS: #1463 and #1473. Now that these two PRs are in, we have a commit to link the header documentation from the table. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Update porting guide for AWS-LC. This is the second phase which includes updated function documentation.
Call-outs:
Originally, this was to include links to the corresponding functions/sections in the new tables as well, but we can't actually provide correct links until we have the correct commit hash in main.
A third phase will link the tables to the corresponding section.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.