Add updated porting guide for AWS-LC#1463
Merged
samuel40791765 merged 3 commits intoaws:mainfrom Mar 7, 2024
Merged
Conversation
1a28d2e to
57955d7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1463 +/- ##
==========================================
+ Coverage 76.99% 77.01% +0.02%
==========================================
Files 425 425
Lines 71587 71627 +40
==========================================
+ Hits 55115 55162 +47
+ Misses 16472 16465 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nebeid
reviewed
Mar 1, 2024
57955d7 to
03f4084
Compare
401c9f6 to
030714c
Compare
nebeid
reviewed
Mar 4, 2024
| <p><span>Not Supported</span></p> | ||
| </td> | ||
| <td> | ||
| <p><span>NO-OP</span></p> |
Contributor
There was a problem hiding this comment.
Should the "Not Supported" Flags have "N/A" instead of NO-OP in Configurability?
Contributor
Author
There was a problem hiding this comment.
No strong opinions here, but I wanted to make the used wording consistent with what was in the text.
| <p> | ||
| <span> | ||
| <a href="https://github.com/aws/aws-lc/blob/5c358103c5df836b9343bf995717b5bc13d5e82f/API-CONVENTIONS.md#thread-safety"> | ||
| Thread Safety |
Contributor
There was a problem hiding this comment.
Is there no header file to be mentioned here where the following values are defined?
Contributor
Author
There was a problem hiding this comment.
Sure, I thought this page had more details, but the introduction at the top of this section explains things well too. Changed.
f31f709 to
98f6223
Compare
98f6223 to
c5eef97
Compare
nebeid
approved these changes
Mar 4, 2024
darylmartin100
approved these changes
Mar 6, 2024
samuel40791765
added a commit
that referenced
this pull request
Apr 26, 2024
This finalizes the changes for the previous two documentation PRS: #1463 and #1473. Now that these two PRs are in, we have a commit to link the header documentation from the table. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Merged
justsmth
added a commit
that referenced
this pull request
Feb 25, 2026
Hello team! I noticed the issue while investigating potential adoption. The porting guide refactor in #1463 missed this. I also took the liberty of splitting the affected run-on sentence. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license. Co-authored-by: Justin W Smith <103147162+justsmth@users.noreply.github.com> Co-authored-by: Nevine Ebeid <66388554+nebeid@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Update porting guide for AWS-LC. This is the first phase, which just includes the text and tables. Second phase will include links to the corresponding functions/sections for the tables along with updated function documentation.
Call-outs:
There were some issues auto-generating the Markdown files with the internal docs. Apparently Markdown doesn't support merged row/columns, so I had to use html instead.
The markdown html has been greatly simplified, so updating it with new functions we find shouldn't be too painful.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.