-
Notifications
You must be signed in to change notification settings - Fork 179
Comparing changes
Open a pull request
base repository: aws/aws-lc
base: v1.66.0
head repository: aws/aws-lc
compare: v1.66.1
- 8 commits
- 29 files changed
- 7 contributors
Commits on Dec 15, 2025
-
Iterate through all DNS entries in connect CLI (#2906)
### Issues: N/A ### Description of changes: The `openssl sclient -connect` CLI command would only attempt to connect to the first resolved DNS entry. Failing that, it considers the entire connection attempt failed. This change updates the command to iterate through the linked list of entries until it can successfully connect. This is in-line with upstream [OpenSSL](https://github.com/openssl/openssl/blob/OpenSSL_1_1_1-stable/apps/s_socket.c#L93). It's particularly useful in cases where the first address resolved is either unavailable or otherwise unusable. This can be common when trying to resolve an address such as `localhost` and the OS returns the ipv6 loopback address before the ipv4 version and your web server is only listening with ipv4. ### Call-outs: I did not exhaustively consider other uses of this function beyond this specific CLI tool. A glance check of the references suggests low usage and it's still the right change to make overall. ### Testing: - Tested this in a build container which resolves `localhost` as `[::1, 127.0.0.1]` with a web server that listens on ipv4 and asserted that the CLI tool can connect successfully to that web server. - CI By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Configuration menu - View commit details
-
Copy full SHA for 5a08a98 - Browse repository at this point
Copy the full SHA 5a08a98View commit details
Commits on Dec 16, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 76a2504 - Browse repository at this point
Copy the full SHA 76a2504View commit details -
Remove OPENSSL_NO_BF for real (#2914)
### Description of changes: File change got lost in a rebase from prior PR. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Configuration menu - View commit details
-
Copy full SHA for b3b2226 - Browse repository at this point
Copy the full SHA b3b2226View commit details -
Add openssl genpkey cli utility tool (#2907)
Internal consumers are depending on the `openssl genpkey` cli tool, so this adds the necessary functionality to support that. This is mainly used for generating a private key or key pair. I've only added the necessary options for now which are `-algorithm`, `-pkeyopt`, and `-out`. We can add more if needed, but there haven't been more use cases discovered yet. I've also reused and cleaned up a bit of the surrounding code while I was at it. Would like to refactor more, but that would be a separate PR. ### Testing: new unit tests. I haven't added any comparison tests, since it didn't really make sense to compare generated private keys from two different libraries. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Configuration menu - View commit details
-
Copy full SHA for 192d915 - Browse repository at this point
Copy the full SHA 192d915View commit details
Commits on Dec 17, 2025
-
Add stdin support for pkcs8 tool (#2915)
There are users that expect the stdin format when using the openssl pkcs8 tool. I've removed some unnecessary cruft. There doesn't seem to be an actual reason to cap the limit here, none of the other cli implement this behavior and the relevant BIO functions will already fail if the file loading becomes too excessive. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Configuration menu - View commit details
-
Copy full SHA for f221856 - Browse repository at this point
Copy the full SHA f221856View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca4a1ba - Browse repository at this point
Copy the full SHA ca4a1baView commit details
Commits on Dec 18, 2025
-
ML-DSA: Missing Private Key Validation Checks (#2874)
### Issue: `EVP_PKEY_pqdsa_new_raw_private_key()` accepts malformed keys with secret vectors `s1` and `s2` containing coefficients outside the valid range `[-η, η]`. These keys lead to undefined behavior, like producing signatures that fail verification. ### Description of changes: Adds the missing validation checks to `ml_dsa_pack_pk_from_sk()` in `crypto/fipsmodule/ml_dsa/ml_dsa_ref/packing.c`. It now rejects keys if `s1` or `s2` have coefficients exceeding `[-η, η]`. ### Call-outs: - With the addition of these validation checks, we should reject *all* invalid private keys. - Discovered via Wycheproof test vector: https://github.com/C2SP/wycheproof/blob/e3c37e9db0f85a762dfcef1642b046bd31090ca4/testvectors_v1/mldsa_44_sign_noseed_test.json#L626-L646 - **Upstream considerations**: While this change should ideally be made upstream in mldsa-native, we are landing this now since this code is in production and mldsa-native will take time to land. I will open an upstream PR soon to ensure consistency. - **Import protection**: If these checks get overridden during a future upstream import, the tests added in this PR will fail in CI, preventing that merge and ensuring the validation remains in place. ### Testing: - Adds test vector generation script `crypto/fipsmodule/ml_dsa/make_corrupted_key_tests.cc` - Adds the generated test vectors `crypto/evp_extra/mldsa_corrupted_key_tests.txt` - Adds a test `crypto/evp_extra/mldsa_test.cc` that uses these test vectors To run the test: ``` $ cd build $ ./crypto/crypto_test --gtest_filter="*MLDSATest.ExpandedKeyValidation*" ``` To (re-)generate the test vectors: ``` $ cd crypto/fipsmodule/ml_dsa $ make generate ``` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Configuration menu - View commit details
-
Copy full SHA for 26cfa36 - Browse repository at this point
Copy the full SHA 26cfa36View commit details -
### Description of changes: Prepare release Prepare v1.66.1 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Configuration menu - View commit details
-
Copy full SHA for 3eb8d55 - Browse repository at this point
Copy the full SHA 3eb8d55View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.66.0...v1.66.1