Add openssl genpkey cli utility tool#2907
Merged
samuel40791765 merged 2 commits intoaws:mainfrom Dec 16, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2907 +/- ##
==========================================
+ Coverage 78.15% 78.17% +0.02%
==========================================
Files 687 689 +2
Lines 118579 118634 +55
Branches 16671 16685 +14
==========================================
+ Hits 92671 92745 +74
+ Misses 25019 25002 -17
+ Partials 889 887 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
WillChilds-Klein
left a comment
There was a problem hiding this comment.
some minor comments, rest LGTM
WillChilds-Klein
approved these changes
Dec 16, 2025
justsmth
approved these changes
Dec 16, 2025
m271828
pushed a commit
to m271828/aws-lc
that referenced
this pull request
Dec 19, 2025
Internal consumers are depending on the `openssl genpkey` cli tool, so this adds the necessary functionality to support that. This is mainly used for generating a private key or key pair. I've only added the necessary options for now which are `-algorithm`, `-pkeyopt`, and `-out`. We can add more if needed, but there haven't been more use cases discovered yet. I've also reused and cleaned up a bit of the surrounding code while I was at it. Would like to refactor more, but that would be a separate PR. ### Testing: new unit tests. I haven't added any comparison tests, since it didn't really make sense to compare generated private keys from two different libraries. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves
P342458515Description of changes:
Internal consumers are depending on the
openssl genpkeycli tool, so this adds the necessary functionality to support that. This is mainly used for generating a private key or key pair.I've only added the necessary options for now which are
-algorithm,-pkeyopt, and-out. We can add more if needed, but there haven't been more use cases discovered yet. I've also reused and cleaned up a bit of the surrounding code while I was at it. Would like to refactor more, but that would be a separate PR.Call-outs:
N/A
Testing:
new unit tests. I haven't added any comparison tests, since it didn't really make sense to compare generated private keys from two different libraries.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.