Skip to content

Add stdin support for pkcs8 tool#2915

Merged
samuel40791765 merged 1 commit intoaws:mainfrom
samuel40791765:pkcs8-stdin
Dec 17, 2025
Merged

Add stdin support for pkcs8 tool#2915
samuel40791765 merged 1 commit intoaws:mainfrom
samuel40791765:pkcs8-stdin

Conversation

@samuel40791765
Copy link
Copy Markdown
Contributor

Description of changes:

There are users that expect the stdin format when using the openssl pkcs8 tool. I've removed some unnecessary cruft. There doesn't seem to be an actual reason to cap the limit here, none of the other cli implement this behavior and the relevant BIO functions will already fail if the file loading becomes too excessive.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@samuel40791765 samuel40791765 requested a review from a team as a code owner December 17, 2025 01:59
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 17, 2025

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.15%. Comparing base (192d915) to head (bf033d0).

Files with missing lines Patch % Lines
tool-openssl/pkcs8.cc 77.77% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2915   +/-   ##
=======================================
  Coverage   78.15%   78.15%           
=======================================
  Files         689      689           
  Lines      118633   118610   -23     
  Branches    16684    16676    -8     
=======================================
- Hits        92718    92704   -14     
+ Misses      25025    25019    -6     
+ Partials      890      887    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samuel40791765 samuel40791765 enabled auto-merge (squash) December 17, 2025 19:21
@samuel40791765 samuel40791765 merged commit f221856 into aws:main Dec 17, 2025
424 of 430 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants