chore(synthetics): add nodejs puppeteer 8 runtime by mazyu36 · Pull Request #30851 · aws/aws-cdk

mazyu36 · 2024-07-15T01:07:36Z

Issue # (if applicable)

Reason for this change

Add new runtime

https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Library_nodejs_puppeteer.html#CloudWatch_Synthetics_runtimeversion-nodejs-puppeteer-8.0

Description of changes

Add new runtime

Description of how you validated changes

No test added because just add runtime enum.

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

ChakshuGupta13 · 2024-07-15T05:47:33Z

packages/aws-cdk-lib/aws-synthetics/lib/runtime.ts

+   *
+   * @see https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Library_nodejs_puppeteer.html#CloudWatch_Synthetics_runtimeversion-nodejs-puppeteer-8.0
+   */
+  public static readonly SYNTHETICS_NODEJS_PUPPETEER_8_0 = new Runtime('syn-nodejs-puppeteer-8.0', RuntimeFamily.NODEJS);


will it not be better to have test(s) which utilise this enum for successful synthesis?
(note: not sure if it is possible to add such a test)

@ChakshuGupta13
Thanks.
I've added a unit test and an integ test to verify deploying new runtime Canary.

ChakshuGupta13 · 2024-07-15T05:49:49Z

packages/aws-cdk-lib/aws-synthetics/lib/runtime.ts

   * - **Bug fixes**
   *
-   * @see https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Library_nodejs_puppeteer.html#CloudWatch_Synthetics_runtimeversion-nodejs-puppeteer-6.1
+   * @see https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Library_nodejs_puppeteer.html#CloudWatch_Synthetics_runtimeversion-nodejs-puppeteer-6.2


nit: this change, although necessary, may get hidden in history because it is being done with addition of Node.js puppeteer 8 runtime, hence, is it possible to take this separately (if not much effort required)?

@ChakshuGupta13
Thanks.
I've separated a PR #30853 to fix wrong link.

ChakshuGupta13 · 2024-07-15T09:19:14Z

...-cdk-testing/framework-integ/test/aws-synthetics/test/integ.canary-sys-nodejs-puppeteer-8.ts

+import * as cdk from 'aws-cdk-lib/core';
+import { Canary, Cleanup, Code, Runtime, Schedule, Test } from 'aws-cdk-lib/aws-synthetics';
+import { IntegTest } from '@aws-cdk/integ-tests-alpha';
+const app = new cdk.App();


nit: an empty line between imports and logic will be better?

Thanks. I've added.

Fix wrong link in syn-nodejs-puppeteer 6.2. I discovered this while working on #30851. I was [advised](#30851 (comment)) to separate the PRs, so I'm creating this as a new PR. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

scanlonp

This looks great! Couple comments on organization.

I appreciate the integ test, but I think we can roll it into the integ.canary.ts test. I do not think we need a full new test just for this runtime.
On the unit test, I see the only version of puppeteer we use is 3.8 (which is long deprecated). Instead of the single new test, what happens if we update all the versions to 8.0. With any luck, everything works without hiccups! If not, we can reconsider.

Pull request has been modified.

mazyu36 · 2024-07-17T11:54:21Z

@scanlonp
Thank you for your review. I agree that your suggestions are better, so I have made the modifications.

Added new runtime test to integ.canary.ts.
Modified the runtime of existing unit tests.

scanlonp

Nice work! Thanks for adding this in @mazyu36!

mergify · 2024-07-17T17:49:00Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2024-07-17T17:53:01Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

lbadger · 2024-07-17T19:03:32Z

Nice I was waiting for this!

mazyu36 · 2024-07-17T22:09:12Z

@scanlonp
Thank you for the approval!
However, it seems that the merge process is being blocked by aws/aws-cdk-owners. I don't understand the reason for the block...
Do you know how I can resolve this?

scanlonp · 2024-07-18T02:00:19Z

Hey @mazyu36, that's saying we need 2 approvals for merge. It's a new process we are trying out. I'll see if I can get someone else to take a look at this and approve.

I would not worry too much about it for now. Our next release will be next week, and I'll make sure this is in by then!

mazyu36 · 2024-07-18T02:53:05Z

@scanlonp
Thank you for the explanation! I understand.
I'm looking forward to seeing the process move forward!

aws-cdk-automation · 2024-07-18T18:44:20Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 0f4cac7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2024-07-18T18:44:42Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2024-07-25T17:41:47Z

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

aws-cdk-automation requested a review from a team July 15, 2024 01:07

github-actions bot added feature-request A feature should be added or improved. p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK labels Jul 15, 2024

feat: add nodejs puppeter 8 runtime

94c349c

mazyu36 force-pushed the synthetics-node-puppeteer8 branch from a1b3776 to 94c349c Compare July 15, 2024 01:12

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 15, 2024

ChakshuGupta13 reviewed Jul 15, 2024

View reviewed changes

mazyu36 mentioned this pull request Jul 15, 2024

docs(synthetics): fix syn-nodejs-puppeteer 6.2 link #30853

Merged

1 task

ChakshuGupta13 approved these changes Jul 15, 2024

View reviewed changes

scanlonp previously requested changes Jul 16, 2024

View reviewed changes

scanlonp self-assigned this Jul 16, 2024

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 16, 2024

fix unit test and integ test

6db5212

mazyu36 force-pushed the synthetics-node-puppeteer8 branch from 44a337a to 6db5212 Compare July 17, 2024 11:22

Merge branch 'main' into synthetics-node-puppeteer8

31db06a

mazyu36 requested a review from scanlonp July 17, 2024 11:54

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 17, 2024

scanlonp approved these changes Jul 17, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 17, 2024

Merge branch 'main' into synthetics-node-puppeteer8

0f4cac7

mergify bot merged commit bbf1ad4 into aws:main Jul 18, 2024

mazyu36 deleted the synthetics-node-puppeteer8 branch July 18, 2024 23:04

github-actions bot mentioned this pull request Jul 22, 2024

Weekly PR metrics report #30917

Closed

aws locked as resolved and limited conversation to collaborators Jul 25, 2024

Conversation

mazyu36 commented Jul 15, 2024

Issue # (if applicable)

Reason for this change

Description of changes

Description of how you validated changes

Checklist

Uh oh!

ChakshuGupta13 Jul 15, 2024

Choose a reason for hiding this comment

Uh oh!

mazyu36 Jul 15, 2024

Choose a reason for hiding this comment

Uh oh!

ChakshuGupta13 Jul 15, 2024

Choose a reason for hiding this comment

Uh oh!

mazyu36 Jul 15, 2024

Choose a reason for hiding this comment

Uh oh!

ChakshuGupta13 Jul 15, 2024

Choose a reason for hiding this comment

Uh oh!

mazyu36 Jul 15, 2024

Choose a reason for hiding this comment

Uh oh!

scanlonp left a comment

Choose a reason for hiding this comment

Uh oh!

mazyu36 commented Jul 17, 2024

Uh oh!

scanlonp left a comment

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Jul 17, 2024

Uh oh!

mergify bot commented Jul 17, 2024

Uh oh!

lbadger commented Jul 17, 2024

Uh oh!

mazyu36 commented Jul 17, 2024

Uh oh!

scanlonp commented Jul 18, 2024

Uh oh!

mazyu36 commented Jul 18, 2024

Uh oh!

aws-cdk-automation commented Jul 18, 2024

AWS CodeBuild CI Report

Uh oh!

mergify bot commented Jul 18, 2024

Uh oh!

aws-cdk-automation commented Jul 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants