Skip to content

docs(synthetics): fix syn-nodejs-puppeteer 6.2 link#30853

Merged
mergify[bot] merged 3 commits intoaws:mainfrom
mazyu36:synthetics-fix-node-6-2-link
Jul 16, 2024
Merged

docs(synthetics): fix syn-nodejs-puppeteer 6.2 link#30853
mergify[bot] merged 3 commits intoaws:mainfrom
mazyu36:synthetics-fix-node-6-2-link

Conversation

@mazyu36
Copy link
Copy Markdown
Contributor

@mazyu36 mazyu36 commented Jul 15, 2024

Fix wrong link in syn-nodejs-puppeteer 6.2.

I discovered this while working on #30851.
I was advised to separate the PRs, so I'm creating this as a new PR.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team July 15, 2024 06:40
@github-actions github-actions bot added star-contributor [Pilot] contributed between 25-49 PRs to the CDK p2 labels Jul 15, 2024
@mazyu36 mazyu36 mentioned this pull request Jul 15, 2024
Merged
1 task
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 15, 2024
scanlonp
scanlonp previously approved these changes Jul 15, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find here, thanks!

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 15, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 15, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 15, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 15, 2024

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/issue-label-assign.yml without workflows permission

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 15, 2024

requeue

❌ Command disallowed due to command restrictions in the Mergify configuration.

Details
  • sender-permission>=write

@mergify mergify bot dismissed scanlonp’s stale review July 16, 2024 00:05

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 16, 2024
@mazyu36
Copy link
Copy Markdown
Contributor Author

mazyu36 commented Jul 16, 2024 •
edited
Loading

@scanlonp
Thank you for the approval. The following error occurred, so I referred to the approaches from past PRs and merged main into this branch.
Could you please approve again?
Also, since I don't fully understand the error content, please let me know if my approach was incorrect.
IMG_3319

@mazyu36 mazyu36 requested a review from scanlonp July 16, 2024 00:36
@scanlonp
Copy link
Copy Markdown
Contributor

scanlonp commented Jul 16, 2024

@mazyu36 fun. Merging from main is the right approach, but of course is does dismiss the review. Approving again.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 16, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 16, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jul 16, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c44ccae
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 0155776 into aws:main Jul 16, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 16, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mazyu36 mazyu36 deleted the synthetics-fix-node-6-2-link branch July 17, 2024 22:49
@github-actions github-actions bot mentioned this pull request Jul 22, 2024
Closed
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jul 25, 2024

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@ChakshuGupta13 ChakshuGupta13 ChakshuGupta13 approved these changes

@scanlonp scanlonp scanlonp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mazyu36 @scanlonp @aws-cdk-automation @ChakshuGupta13