Conversation
| export enum CustomLayer { | ||
| /** | ||
| * The POI custom layer adds a richer set of places, such as shops, services, restaurants, attractions, and other points of interest to your map. | ||
| * Currently only the VectorEsriNavigation map style supports the POI custom layer. |
There was a problem hiding this comment.
I considered adding this validation, but decided against it as I thought the scope might expand in the future, potentially making it unnecessary. Please provide any opinions if you have them.
| /** | ||
| * An India (IND) political view | ||
| */ | ||
| INDIA = 'IND', |
There was a problem hiding this comment.
According to docs, political view can only be used with specific styles. However, considering the possibility that future AWS updates might expand its applicability, I have decided not to add validation at this time.
Please provide any feedback if you have any.
6945287 to
9d9b731
Compare
c65cae2 to
91e92e2
Compare
…x class (#30974) ### Issue # (if applicable) N/A ### Reason for this change Add validation for PlaceIndex description, similar to #30648, #30682, and #30711 . ### Description of changes Add validation and unit tests for description. ### Description of how you validated changes Add unit tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
badmintoncryer
left a comment
There was a problem hiding this comment.
I've added some minor comments.
| })).toThrow('`description` must be between 0 and 1000 characters. Received: 1001 characters'); | ||
| }); | ||
|
|
||
| test('throws with invalid name', () => { |
There was a problem hiding this comment.
How about adding the test about invalid name length?
There was a problem hiding this comment.
Thanks. I've added a test.
Also I've refactored the code to separate the regex pattern check and length check, as I think it would be more user-friendly.
|
@badmintoncryer |
badmintoncryer
left a comment
There was a problem hiding this comment.
Please delete only the tests that were likely left behind by mistake!
GavinZZ
left a comment
There was a problem hiding this comment.
Really high quality PR, appreciate it!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #30648 +/- ##
=======================================
Coverage 77.17% 77.17%
=======================================
Files 105 105
Lines 7169 7169
Branches 1315 1315
=======================================
Hits 5533 5533
Misses 1455 1455
Partials 181 181
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #30647.
Reason for this change
In aws-location-alpha,
maphas not been supported yet.Description of changes
Add
Mapclass.Description of how you validated changes
Add a unit test and a integ test.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license