chore(location): add validation for description property in PlaceIndex class#30974
chore(location): add validation for description property in PlaceIndex class#30974mergify[bot] merged 3 commits intoaws:mainfrom
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
Exemption Request: As this only adding validation, I think updating the README and integration tests is not needed. |
go-to-k
left a comment
There was a problem hiding this comment.
Could you add a description for the character count constraint to JSDoc for the property? It would surely benefit users.
|
@go-to-k |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
TheRealAmazonKendra
left a comment
There was a problem hiding this comment.
I've updated this to a chore, which has different validation for the PR.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
N/A
Reason for this change
Add validation for PlaceIndex description, similar to #30648, #30682, and #30711 .
Description of changes
Add validation and unit tests for description.
Description of how you validated changes
Add unit tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license