chore(eks): update eks compare-log unit test to use sdk v3#29845
Merged
mergify[bot] merged 1 commit intomainfrom Apr 15, 2024
Merged
chore(eks): update eks compare-log unit test to use sdk v3#29845mergify[bot] merged 1 commit intomainfrom
mergify[bot] merged 1 commit intomainfrom
Conversation
…om custom-resource-handlers Signed-off-by: Francis <colifran@amazon.com>
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
vinayak-kukreja
approved these changes
Apr 15, 2024
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Merged
1 task
mergify bot
pushed a commit
that referenced
this pull request
Apr 17, 2024
…sSdkCall` in unit tests (#29860) ### Reason for this change #29648 introduced a change to the `AwsSdkCall` representation used in the v2 and v3 handler code. Our handler unit tests use `satisfies` to validate that the event object satisfies `AwsSdkCall`. All unit tests and the build still pass, but the linter calls out that the event object doesn't actually satisfy `AwsSdkCall`. #29845 removed the dependency `@aws-cdk/custom-resource-handlers` had on `aws-sdk`. We should add this as devDependency since we're using `aws-sdk` in v2 handler mocks. ### Description of changes I added `logApiResponseData` property to the event objects being tested to make the event satisfy `AwsSdkCall`. I added `aws-sdk` as a dev dependency. We will remove this as part of the v2 handler removal. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Collaborator
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this change
The AWS SDK V2 is being deprecated. We need to remove all uses of it from the CDK.
Description of changes
The
compare-logunit test for theaws-ekscompareLogging.tswas usingCreateClusterRequestandLogTypesfrom AWS SDK V2. I've updated the code to use theCreateClusterRequestandLogTypefrom AWS SDK V3. Additionally, with this change,aws-sdkis no longer needed as a dependency for@aws-cdk/custom-resource-handlers.Description of how you validated changes
This change does not impact
compareLogging.ts. Consequently, we just need to verify that the unit tests incompare-log.test.tsare still successful. I have validated that these are still passing.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license