chore: add aws-sdk as dev dependency for unit tests and satisfy AwsSdkCall in unit tests#29860
chore: add aws-sdk as dev dependency for unit tests and satisfy AwsSdkCall in unit tests#29860mergify[bot] merged 3 commits intomainfrom
aws-sdk as dev dependency for unit tests and satisfy AwsSdkCall in unit tests#29860Conversation
Signed-off-by: Francis <colifran@amazon.com>
AwsSdkCall in unit testsaws-sdk dependency for unit tests and satisfy AwsSdkCall in unit tests
Signed-off-by: Francis <colifran@amazon.com>
aws-sdk dependency for unit tests and satisfy AwsSdkCall in unit testsaws-sdk as dev dependency for unit tests and satisfy AwsSdkCall in unit tests
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Reason for this change
#29648 introduced a change to the
AwsSdkCallrepresentation used in the v2 and v3 handler code. Our handler unit tests usesatisfiesto validate that the event object satisfiesAwsSdkCall. All unit tests and the build still pass, but the linter calls out that the event object doesn't actually satisfyAwsSdkCall.#29845 removed the dependency
@aws-cdk/custom-resource-handlershad onaws-sdk. We should add this as devDependency since we're usingaws-sdkin v2 handler mocks.Description of changes
I added
logApiResponseDataproperty to the event objects being tested to make the event satisfyAwsSdkCall. I addedaws-sdkas a dev dependency. We will remove this as part of the v2 handler removal.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license