fix(ecs-patterns): integ test failed with certificate error#29649
Closed
wafuwafu13 wants to merge 2 commits intoaws:mainfrom
Closed
fix(ecs-patterns): integ test failed with certificate error#29649wafuwafu13 wants to merge 2 commits intoaws:mainfrom
wafuwafu13 wants to merge 2 commits intoaws:mainfrom
Conversation
Contributor
Author
|
Build is failed, but I think destructive changes are necessary. @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3468774902/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-ecs-patterns/test/fargate/integ.alb-fargate-service-https.js
@aws-cdk-testing/framework-integ: !!! This test contains destructive changes !!!
@aws-cdk-testing/framework-integ: Stack: aws-ecs-integ-alb-fg-https - Resource: myServiceCertificate152F9DDA - Impact: WILL_REPLACE
@aws-cdk-testing/framework-integ: Stack: aws-ecs-integ-alb-fg-https - Resource: myServiceDNSD76FB53A - Impact: WILL_REPLACE
@aws-cdk-testing/framework-integ: !!! If these destructive changes are necessary, please indicate this on the PR !!!
@aws-cdk-testing/framework-integ: Error: Some changes were destructive!
@aws-cdk-testing/framework-integ: at main (/codebuild/output/src3468774902/src/github.com/aws/aws-cdk/packages/@aws-cdk/integ-runner/lib/cli.js:183:15)
@aws-cdk-testing/framework-integ: Error: integ-runner exited with error code 1
@aws-cdk-testing/framework-integ: Tests failed. Total time (1m52.8s) | integ-runner (1m39.2s) | /codebuild/output/src3468774902/src/github.com/aws/aws-cdk/node_modules/jest/bin/jest.js (12.4s) |
1 task
This was referenced Apr 1, 2024
Contributor
Oh, this is totally fine because you are changing the integ test and not the resource. You can run them again with |
8a2e2e9 to
5b36ab5
Compare
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
mergify bot
pushed a commit
that referenced
this pull request
Apr 17, 2024
### Issue # (if applicable) Part of: #29186 (comment) ### Reason for this change `aws-ecs-patterns/test/fargate/integ.alb-fargate-service-https-idle-timeout` was failed with certificate error (#29186 (comment)). It is enough to set `idleTimeout` property to test loadbalancer with idleTimeout. `aws-ecs-patterns/test/fargate/integ.alb-fargate-service-https` is also failed with certificate error so I will fix at another PR #29649. ### Description of changes - Rename `aws-ecs-patterns/test/fargate/integ.alb-fargate-service-https-idle-timeout.ts` to `aws-ecs-patterns/test/fargate/integ.alb-fargate-service-idle-timeout.ts` - Remove unnecessary property - Run `yarn integ` ### Description of how you validated changes - Pass integ test ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Part of: #29186 (comment)
Reason for this change
aws-ecs-patterns/test/fargate/integ.alb-fargate-service-httpswas failed with certificate error (#29186 (comment)) becausedomainName,hostedZoneId,zoneNameare hard-coded.Description of changes
Set
domainName,hostedZoneId,zoneNameto environment variableref:
aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-route53-patterns/test/integ.hosted-redirect-same-region.ts
Lines 6 to 11 in dffedca
enableECSManagedTagsandenableECSManagedTagsproperties are not needed for test httpsRun
yarn integDescription of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license