Skip to content

fix(ecs-patterns): integ test failed with certificate error#29623

Merged
mergify[bot] merged 3 commits intoaws:mainfrom
wafuwafu13:integ-fargate-idle
Apr 17, 2024
Merged

fix(ecs-patterns): integ test failed with certificate error#29623
mergify[bot] merged 3 commits intoaws:mainfrom
wafuwafu13:integ-fargate-idle

Conversation

@wafuwafu13
Copy link
Copy Markdown
Contributor

@wafuwafu13 wafuwafu13 commented Mar 26, 2024 •
edited
Loading

Issue # (if applicable)

Part of: #29186 (comment)

Reason for this change

aws-ecs-patterns/test/fargate/integ.alb-fargate-service-https-idle-timeout was failed with certificate error (#29186 (comment)).
It is enough to set idleTimeout property to test loadbalancer with idleTimeout.

aws-ecs-patterns/test/fargate/integ.alb-fargate-service-https is also failed with certificate error so I will fix at another PR #29649.

Description of changes

  • Rename aws-ecs-patterns/test/fargate/integ.alb-fargate-service-https-idle-timeout.ts to aws-ecs-patterns/test/fargate/integ.alb-fargate-service-idle-timeout.ts
  • Remove unnecessary property
  • Run yarn integ

Description of how you validated changes

  • Pass integ test

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK labels Mar 26, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team March 26, 2024 20:17
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 26, 2024
lpizzinidev
lpizzinidev approved these changes Mar 31, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Mar 31, 2024
This was referenced Apr 1, 2024
Closed
Closed
godwingrs22
godwingrs22 previously approved these changes Apr 12, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@godwingrs22 godwingrs22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 12, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 12, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 12, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@TheRealAmazonKendra
Copy link
Copy Markdown
Contributor

TheRealAmazonKendra commented Apr 17, 2024

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 17, 2024

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/request-cli-integ-test.yml without workflows permission

@mergify mergify bot dismissed godwingrs22’s stale review April 17, 2024 01:47

Pull request has been modified.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 17, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Apr 17, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ece19cc
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 5347369 into aws:main Apr 17, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 17, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

This was referenced May 23, 2024
Open
Open
@NOUIY NOUIY mentioned this pull request May 30, 2024
Open
@NOUIY NOUIY mentioned this pull request Jun 7, 2024
Open
@niravparikh05 niravparikh05 mentioned this pull request Jun 13, 2024
Open
@NOUIY NOUIY mentioned this pull request Jun 14, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Jun 20, 2024
Closed
This was referenced Jun 20, 2024
Open
Open
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jul 25, 2024

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@TheRealAmazonKendra TheRealAmazonKendra TheRealAmazonKendra approved these changes

+2 more reviewers

@lpizzinidev lpizzinidev lpizzinidev approved these changes

@godwingrs22 godwingrs22 godwingrs22 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wafuwafu13 @TheRealAmazonKendra @aws-cdk-automation @godwingrs22 @lpizzinidev