Skip to content

chore(tool): Run projen for node-bundle#26468

Closed
matt9ucci wants to merge 1 commit intoaws:mainfrom
matt9ucci:run-projen-for-node-bundle
Closed

chore(tool): Run projen for node-bundle#26468
matt9ucci wants to merge 1 commit intoaws:mainfrom
matt9ucci:run-projen-for-node-bundle

Conversation

@matt9ucci
Copy link
Copy Markdown
Contributor

@matt9ucci matt9ucci commented Jul 21, 2023

Run projen for node-bundle

Execute npx lerna run projen --scope=@aws-cdk/node-bundle and commit the updated files.
The updates include:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jul 21, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team July 21, 2023 17:55
@github-actions github-actions bot added the p2 label Jul 21, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Jul 21, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@matt9ucci matt9ucci changed the title Run projen for node-bundle fix(tool): Run projen for node-bundle Jul 21, 2023
@matt9ucci
Copy link
Copy Markdown
Contributor Author

matt9ucci commented Jul 21, 2023

Exemption Request
This PR does not affect the test.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Jul 21, 2023
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jul 21, 2023

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 57d1acc
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 21, 2023
@matt9ucci matt9ucci changed the title fix(tool): Run projen for node-bundle chore(tool): Run projen for node-bundle Jul 21, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 21, 2023 18:32

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

mrgrain
mrgrain requested changes Jul 25, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @matt9ucci Thanks for this PR! I see why you did this. But I'd actually rather have projen removed from this package. Doesn't really make sense to mix the tooling here. LMK if you want to take this, otherwise feel free to close the PR.

@matt9ucci
Copy link
Copy Markdown
Contributor Author

matt9ucci commented Jul 26, 2023

@mrgrain Thank you for your reply. I will close the PR.

I was trying to build aws-cdk-lib on Windows, but node-bundle threw the following error:

$ npx lerna run build --scope=aws-cdk-lib
...
> @aws-cdk/node-bundle:build

yarn run v1.22.19
$ projen build
\"" was unexpected at this time.
👾 unable to evaluate environment variable PATH=$(npx -c "node -e \"console.log(process.env.PATH)\""): unknown error
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

It is due to the old version of projen. If projen is removed, the error is removed too. That's okay.

@matt9ucci matt9ucci closed this Jul 26, 2023
@mrgrain mrgrain mentioned this pull request Jul 26, 2023
Merged
mergify bot pushed a commit that referenced this pull request Jul 26, 2023
@mrgrain
chore(node-bundle): remove projen (#26518)
e53e8dc 
We don't have a mechanism to keep a projen project up to date.
It's better if all packages in a monorepo use the same tooling.

Replaces #26468 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@matt9ucci matt9ucci deleted the run-projen-for-node-bundle branch July 28, 2023 10:54
bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this pull request Jul 29, 2023
@mrgrain @bmoffatt
chore(node-bundle): remove projen (aws#26518)
7aa3896 
We don't have a mechanism to keep a projen project up to date.
It's better if all packages in a monorepo use the same tooling.

Replaces aws#26468 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrgrain mrgrain mrgrain requested changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

No one assigned

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matt9ucci @aws-cdk-automation @mrgrain