Skip to content

fix(node): print PATH without escaping double quotes#2719

Merged
mergify[bot] merged 1 commit intoprojen:mainfrom
matt9ucci:node-project-envcommand
Jun 6, 2023
Merged

fix(node): print PATH without escaping double quotes#2719
mergify[bot] merged 1 commit intoprojen:mainfrom
matt9ucci:node-project-envcommand

Conversation

@matt9ucci
Copy link
Copy Markdown
Contributor

Fix #981

To avoid escaping double quotes, use --print option instead of -e console.log().


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 4, 2023

Codecov Report

Merging #2719 (71eb59f) into main (ab5b6be) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #2719   +/-   ##
=======================================
  Coverage   96.30%   96.31%           
=======================================
  Files         181      181           
  Lines       33363    33363           
  Branches     3058     3058           
=======================================
+ Hits        32131    32133    +2     
+ Misses       1232     1230    -2     
Impacted Files Coverage Δ
src/javascript/node-project.ts 93.40% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Copy Markdown
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Task environment shell execution is not working on windows

3 participants