chore(aws-cdk-lib): refactor submodule gen#25543
Merged
mergify[bot] merged 8 commits intomainfrom May 11, 2023
Merged
Conversation
|
|
Naumel
approved these changes
May 11, 2023
Contributor
Naumel
left a comment
There was a problem hiding this comment.
Code looks good to me, adding the label in case a second pair of eyes is needed
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
corymhall
added a commit
that referenced
this pull request
May 12, 2023
This is a backport of #25543 with changes specific to v1. - Spec update won't fail in the bump job (it will fail in the PR build) - New modules are generated again
mergify bot
pushed a commit
that referenced
this pull request
May 12, 2023
This is a backport of #25543 with changes specific to v1. - Spec update won't fail in the bump job (it will fail in the PR build) - New modules are generated again ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submodule generation is split between
cfn2tsandaws-cdk-lib/scripts/gen.ts.This PR re-organizes the responsibilities between the packages.
cfn2tsis now only responsible for generating L1 files (including Canned Metrics and Augmentations).Any further code gen related to the specific submodule setup in
aws-cdk-libhas been moved there.This will make it easier to replace
cfn2tswith a new version.Also fixes a few minor issue on the way:
lazy-index.tsagainWith this clean-up version in place, we can now go and add submodule generation as a step of the spec update.
Additionally, spec patches can now be less strict and will continue even on failure.
This is to facilitate the spec bump job, which will do that.
PR builds continue to be strict and will fail.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license