Skip to content

chore(cfnspec): fix cfnspec upgrade job#25564

Merged
mergify[bot] merged 2 commits intov1-mainfrom
corymhall/dont-fail-on-cfnspec-bump
May 12, 2023
Merged

chore(cfnspec): fix cfnspec upgrade job#25564
mergify[bot] merged 2 commits intov1-mainfrom
corymhall/dont-fail-on-cfnspec-bump

Conversation

@corymhall
Copy link
Copy Markdown
Contributor

This is a backport of #25543 with changes specific to v1.

  • Spec update won't fail in the bump job (it will fail in the PR build)
  • New modules are generated again

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

This is a backport of #25543 with changes specific to v1.

- Spec update won't fail in the bump job (it will fail in the PR build)
- New modules are generated again
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented May 12, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team May 12, 2023 15:41
@github-actions github-actions bot added the p2 label May 12, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 12, 2023
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This stuff was accidentally removed in a previous PR that backported stuff from v2.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This content was accidentally removed in a previous PR that backported something from v2.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: e823576
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 24a70d9 into v1-main May 12, 2023
@mergify mergify bot deleted the corymhall/dont-fail-on-cfnspec-bump branch May 12, 2023 17:18
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants