fix(step-functions): arn is not valid across partitions#22314
Merged
mergify[bot] merged 3 commits intomainfrom Oct 2, 2022
Merged
fix(step-functions): arn is not valid across partitions#22314mergify[bot] merged 3 commits intomainfrom
mergify[bot] merged 3 commits intomainfrom
Conversation
There were a number of arns with hardcoded formatting in the stepfunctions-tasks module that would cause policies to be invalid across partitions. Updated these to use our standard `Stack.formatArn` functionality.
|
|
aws-cdk-automation
previously requested changes
Sep 30, 2022
Collaborator
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The Pull Request Linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
PRs must pass status checks before we can provide a meaningful review.
Pull Request updated. Dissmissing previous PRLinter Review.
aws-cdk-automation
previously requested changes
Sep 30, 2022
Collaborator
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The Pull Request Linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
PRs must pass status checks before we can provide a meaningful review.
Contributor
|
Added linter exemption given that we see the updates in the snapshots and this doesn't necessarily need another test just for it. |
Pull Request updated. Dissmissing previous PRLinter Review.
Contributor
Author
|
I added a unit test to cover the important bits, there are a lot of integ related changes though, are those normal @TheRealAmazonKendra ? |
Contributor
Yep. This looks exactly as I'd expect for this change. |
TheRealAmazonKendra
approved these changes
Oct 2, 2022
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
arewa
pushed a commit
to arewa/aws-cdk
that referenced
this pull request
Oct 8, 2022
There were a number of arns with hardcoded formatting in the stepfunctions-tasks module that would cause policies to be invalid across partitions. Updated these to use our standard `Stack.formatArn` functionality. ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
4 tasks
mergify bot
pushed a commit
that referenced
this pull request
Oct 28, 2022
…valid s3 arn (#22692) Fixes #22608. The attached issue has all the necessary information, but the gist is that #22314 mistakenly added region/account information to the generated s3 arn, while s3 bucket names are globally unique in a partition: https://docs.aws.amazon.com/AmazonS3/latest/userguide/s3-arn-format.html ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
4 tasks
homakk
pushed a commit
to homakk/aws-cdk
that referenced
this pull request
Dec 1, 2022
There were a number of arns with hardcoded formatting in the stepfunctions-tasks module that would cause policies to be invalid across partitions. Updated these to use our standard `Stack.formatArn` functionality. ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mergify bot
pushed a commit
that referenced
this pull request
Jun 12, 2023
…queryexecution task (#25911) The policy was originally adjusted in #22314 to use `formatArn()` to account for other partitions. However, there were no tests for these policies before this fix, so it was not identified that the policy would start getting incorrectly generated without being able to act on the resources inside a bucket. Closes #25875 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were a number of arns with hardcoded formatting in the stepfunctions-tasks module that would cause policies to be invalid across partitions. Updated these to use our standard
Stack.formatArnfunctionality.All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license