fix(stepfunctions-tasks): incorrect policy generated for athena startqueryexecution task#25911
Conversation
|
|
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
Exemption Request One of our integ tests already generates this policy, and I reran it. Unless we add a verification check that the contents of the bucket can actually be read, I don't think we can do better |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
The policy was originally adjusted in #22314 to use
formatArn()to account for other partitions. However, there were no tests for these policies before this fix, so it was not identified that the policy would start getting incorrectly generated without being able to act on the resources inside a bucket.Closes #25875
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license