fix(cli): format of tags in cdk.json is not validated#21050
Merged
mergify[bot] merged 3 commits intoaws:mainfrom Jul 8, 2022
SydneyUni-Jim:issue-20854
Merged
fix(cli): format of tags in cdk.json is not validated#21050mergify[bot] merged 3 commits intoaws:mainfrom SydneyUni-Jim:issue-20854
mergify[bot] merged 3 commits intoaws:mainfrom
SydneyUni-Jim:issue-20854
Conversation
|
|
If tags is present in cdk.json, validate that it is an array of objects, and each object has a Tag string and a Value string.
Contributor
Author
|
As far as I can read, my tests are passing. It is this that is failing. I don't understand how the two might be connected. |
rix0rrr
previously approved these changes
Jul 8, 2022
rix0rrr
approved these changes
Jul 8, 2022
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
daschaa
pushed a commit
to daschaa/aws-cdk
that referenced
this pull request
Jul 9, 2022
If tags is present in cdk.json, validate that it is an array of objects, and each object has a Tag string and a Value string. If tags is not structurally valid `cdk bootstrap` and `cdk deploy` fail with an error.
`tags must be an array of { Tag: string, Value: string } objects`
There is no attempt to validate the strings of each Tag and Value beyond that they are strings.
closes aws#20854
----
### All Submissions:
* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mergify bot
pushed a commit
that referenced
this pull request
Jul 11, 2022
…ed" (#21092) Reverts #21050 It breaks the CLI integ tests that get run on our internal pipelines. The error message is `Error: tags must be an array of { Tag: string, Value: string } objects`, which comes from the `validateTags` method in #21050. The test runs `cdk deploy --tag key=value` which I was able to test on my own account to verify that that is a valid way of adding tags to a stack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If tags is present in cdk.json, validate that it is an array of objects, and each object has a Tag string and a Value string. If tags is not structurally valid
cdk bootstrapandcdk deployfail with an error.tags must be an array of { Tag: string, Value: string } objectsThere is no attempt to validate the strings of each Tag and Value beyond that they are strings.
closes #20854
All Submissions:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license