fix(cli): revert "fix(cli): format of tags in cdk.json is not validated"#21092
Merged
mergify[bot] merged 1 commit intomainfrom Jul 11, 2022
Merged
fix(cli): revert "fix(cli): format of tags in cdk.json is not validated"#21092mergify[bot] merged 1 commit intomainfrom
mergify[bot] merged 1 commit intomainfrom
Conversation
This reverts commit 8e6a387.
|
|
vinayak-kukreja
approved these changes
Jul 11, 2022
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #21050
It breaks the CLI integ tests that get run on our internal pipelines. The error message is
Error: tags must be an array of { Tag: string, Value: string } objects, which comes from thevalidateTagsmethod in #21050. The test runscdk deploy --tag key=valuewhich I was able to test on my own account to verify that that is a valid way of adding tags to a stack.