chore(cli): remove scary "you shouldn't see this" message#21032
Closed
chore(cli): remove scary "you shouldn't see this" message#21032
Conversation
We thought people shouldn't see this message, but they occasionaly do, which leads
to alarmed bug reports.
It's *probably* okay to remove the `on('timeout')` event handler if we
have to have this one anyway, but I'm not a 100% confident so I'd rather
just make the message less objectionable and have 2 timers, than have 1
and not be sure what's going on.
|
|
Contributor
Author
|
Duplicate of #20308 |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Naumel
added a commit
that referenced
this pull request
Jul 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We thought people shouldn't see this message, but they occasionaly do, which leads
to alarmed bug reports.
It's probably okay to remove the
on('timeout')event handler if wehave to have this one anyway, but I'm not a 100% confident so I'd rather
just make the message less objectionable and have 2 timers, than have 1
and not be sure what's going on.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license