chore(cli): remove scary "you shouldn't see this" message

rix0rrr · rix0rrr · commit 856ef79d4f55 · 2022-07-07T13:57:40.000+02:00
We thought people shouldn't see this message, but they occasionaly do, which leads
to alarmed bug reports.

It's *probably* okay to remove the `on('timeout')` event handler if we
have to have this one anyway, but I'm not a 100% confident so I'd rather
just make the message less objectionable and have 2 timers, than have 1
and not be sure what's going on.
diff --git a/packages/aws-cdk/lib/notices.ts b/packages/aws-cdk/lib/notices.ts
@@ -145,12 +145,11 @@ export class WebsiteNoticeDataSource implements NoticeDataSource {
           req.destroy(new Error('Request timed out'));
         });
 
-        // It's not like I don't *trust* the 'timeout' event... but I don't trust it.
-        // Add a backup timer that will destroy the request after all.
-        // (This is at least necessary to make the tests pass, but that's probably because of 'nock'.
-        // It's not clear whether users will hit this).
+        // This timer is necessary to make the test pass (looks like 'nock' doesn't support the
+        // timeout event), but we're also seeing users hit this in practice. Not exactly sure
+        // what's causing this to fire before the on('timeout') event, but let's have both in place.
         setTimeout(() => {
-          req.destroy(new Error('Request timed out. You should never see this message; if you do, please let us know at https://github.com/aws/aws-cdk/issues'));
+          req.destroy(new Error('Request timed out.'));
         }, timeout + 200);
       } catch (e) {
         reject(new Error(`HTTPS 'get' call threw an error: ${e.message}`));
