docs(opensearch): add example for token based import#20915
Merged
mergify[bot] merged 4 commits intoaws:mainfrom Jul 5, 2022
akleiber:main
Merged
docs(opensearch): add example for token based import#20915mergify[bot] merged 4 commits intoaws:mainfrom akleiber:main
mergify[bot] merged 4 commits intoaws:mainfrom
akleiber:main
Conversation
|
|
Add another example on how to import an existing domain with values from `Fn.importValue()`. Normally one would not put the domain endpoint as a static value in a CF stack. A more realistic use case is to manage an opensearch domain from CF stack A and use it via CF stack B, C, D ... Stack A would export the domainEndpoint and also domainArn - the other stacks can then import those values and import the domain. Documentation for changes made in #15219
kaizencc
reviewed
Jul 1, 2022
kaizencc
approved these changes
Jul 5, 2022
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
daschaa
pushed a commit
to daschaa/aws-cdk
that referenced
this pull request
Jul 9, 2022
Documentation for changes made in PR aws#15219 - issue aws#15188 Normally one would not put the domain endpoint as a static value in a CF stack. A more realistic use case is to manage an opensearch domain from CF stack A and use it via CF stack B, C, D ... Stack A would export the domainEndpoint and also domainArn - the other stacks can then import those values and import the domain. This PR will add an example for the realistic scenario so people do not end up with errors like "Invalid URL" when a token endpoint is provided. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation for changes made in PR #15219 - issue #15188
Normally one would not put the domain endpoint as a static value in a CF stack.
A more realistic use case is to manage an opensearch domain from CF stack A and use it via CF stack B, C, D ...
Stack A would export the domainEndpoint and also domainArn - the other stacks can then import those values and import the domain.
This PR will add an example for the realistic scenario so people do not end up with errors like "Invalid URL" when a token endpoint is provided.
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license