fix(elasticsearch): Domain.fromDomainAttributes gives "Invalid URL" when endpoint is a token#15219
Merged
mergify[bot] merged 3 commits intoaws:masterfrom Jun 22, 2021
Merged
Conversation
Contributor
|
Please add a summary description of the changes contained in this PR |
BenChaimberg
previously requested changes
Jun 21, 2021
Contributor
BenChaimberg
left a comment
There was a problem hiding this comment.
the modes of these files were changed to allow execution; please revert
191c4b5 to
2b2182f
Compare
|
|
…hen endpoint is a token
2b2182f to
d6aad54
Compare
Pull request has been modified.
Contributor
Author
|
@BenChaimberg Updated the PR. Had to change modes due to some permission issue with yarn. Reverted it now, and also modified tests to check equality. |
Contributor
|
Please commit on top, as Github doesn't have great support for diffing between force-pushed commits |
BenChaimberg
approved these changes
Jun 22, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Seiya6329
pushed a commit
to Seiya6329/aws-cdk
that referenced
this pull request
Jun 22, 2021
…hen endpoint is a token (aws#15219) `Domain.fromDomainAttributes` throws the error "Invalid URL" when a token endpoint is provided. In this PR, the domain name is retrieved from the scope using the arn present in `DomainAttributes`, and if no name is found, we try to get it from the endpoint (as it has been done so far). Also added a test to verify that the error disappears with this change, even when it is given token attributes. closes aws#15188 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
matthewsvu
pushed a commit
to matthewsvu/aws-cdk
that referenced
this pull request
Jun 22, 2021
…hen endpoint is a token (aws#15219) `Domain.fromDomainAttributes` throws the error "Invalid URL" when a token endpoint is provided. In this PR, the domain name is retrieved from the scope using the arn present in `DomainAttributes`, and if no name is found, we try to get it from the endpoint (as it has been done so far). Also added a test to verify that the error disappears with this change, even when it is given token attributes. closes aws#15188 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
…hen endpoint is a token (aws#15219) `Domain.fromDomainAttributes` throws the error "Invalid URL" when a token endpoint is provided. In this PR, the domain name is retrieved from the scope using the arn present in `DomainAttributes`, and if no name is found, we try to get it from the endpoint (as it has been done so far). Also added a test to verify that the error disappears with this change, even when it is given token attributes. closes aws#15188 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
4 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jul 5, 2022
Documentation for changes made in PR #15219 - issue #15188 Normally one would not put the domain endpoint as a static value in a CF stack. A more realistic use case is to manage an opensearch domain from CF stack A and use it via CF stack B, C, D ... Stack A would export the domainEndpoint and also domainArn - the other stacks can then import those values and import the domain. This PR will add an example for the realistic scenario so people do not end up with errors like "Invalid URL" when a token endpoint is provided. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
daschaa
pushed a commit
to daschaa/aws-cdk
that referenced
this pull request
Jul 9, 2022
Documentation for changes made in PR aws#15219 - issue aws#15188 Normally one would not put the domain endpoint as a static value in a CF stack. A more realistic use case is to manage an opensearch domain from CF stack A and use it via CF stack B, C, D ... Stack A would export the domainEndpoint and also domainArn - the other stacks can then import those values and import the domain. This PR will add an example for the realistic scenario so people do not end up with errors like "Invalid URL" when a token endpoint is provided. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Domain.fromDomainAttributesthrows the error "Invalid URL" when a token endpoint is provided. In this PR, the domain name is retrieved from the scope using the arn present inDomainAttributes, and if no name is found, we try to get it from the endpoint (as it has been done so far). Also added a test to verify that the error disappears with this change, even when it is given token attributes.closes #15188
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license