fix(ecr-assets): cannot build ARM images using modern stack synthesis#20563
Merged
mergify[bot] merged 2 commits intoaws:masterfrom Jun 1, 2022
Merged
Conversation
|
|
rix0rrr
approved these changes
Jun 1, 2022
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
olizilla
added a commit
to web3-storage/pickup
that referenced
this pull request
Aug 17, 2022
- Adds a dockerfile to init kubo with customised config. - Updating sst and aws-sdk-lib so we can set the platform per aws/aws-cdk#20563 - Without this, the images built locally are platform dependant, and will fail if built from, say, and an `arm64` machine. fixes #9 fixes #21 License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#20439 added support for the --platform option for docker build but the platform prop was not properly passed through when using the new DefaultStackSynthesizer.
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license