Conversation
- Adds a dockerfile to init kubo with customised config. - Forces platform to amd64 for images intended to run in ECS. I can't see a way to configure aws-cdk to set the platform when building, so we have to force it in the docker file. Thanks to https://stackoverflow.com/a/70614305/6490163 fixes #9 fixes #21 License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
olizilla
commented
Aug 16, 2022
Dockerfile
Outdated
| @@ -1,5 +1,5 @@ | |||
| # I build the pickup worker that subscribes to the SQS Queue. | |||
| FROM node:16-alpine | |||
| FROM --platform=linux/amd64 node:16-alpine | |||
Contributor
Author
There was a problem hiding this comment.
The real fix here would be to teach aws-cdk to let us specify the platform build arg when it runs the build but that is a harder path.
Contributor
Author
|
Oh my aws/aws-cdk#12472 |
Contributor
Author
|
So the real fix exists and was merged in this PR aws/aws-cdk#20563 but we SST requires we stick to a specific version of the aws-cdk for things to work, so we need to wait for an SST update to get it. |
alanshaw
approved these changes
Aug 16, 2022
Contributor
Author
$ npx sst update v1.7.0
Updating @serverless-stack/cli to v1.7.0
Updating @serverless-stack/resources to v1.7.0
Updating aws-cdk-lib@2.32.0
SST: 1.7.0
CDK: 2.32.0
|
dont mess with the dockerfiles, force the platform in the infra code where we know the target arch. License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
arm64machine.I can't see a way to configure aws-cdk to set the platform when building, so we have to force it in the docker file. Thanks to https://stackoverflow.com/a/70614305/6490163fixes #9
fixes #20
License: MIT
Signed-off-by: Oli Evans oli@protocol.ai