Skip to content

chore(core): revert "allow disabling of LogicalID Metadata in case of large manifest"#20421

Merged
mergify[bot] merged 1 commit intomasterfrom
revert-20387-optionalMetadata
May 19, 2022
Merged

chore(core): revert "allow disabling of LogicalID Metadata in case of large manifest"#20421
mergify[bot] merged 1 commit intomasterfrom
revert-20387-optionalMetadata

Conversation

@Chriscbr
Copy link
Copy Markdown
Contributor

#20387 tests fail on our merge to v2, likely because CDK v2 uses the new style stack synthesis by default and generates a lot more metadata. Reverting for now to unblock the release.

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented May 19, 2022

@Chriscbr Chriscbr changed the title Revert "feat(core): allow disabling of LogicalID Metadata in case of large manifest" chore(core): revert "allow disabling of LogicalID Metadata in case of large manifest" May 19, 2022
@github-actions github-actions bot added the p2 label May 19, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team May 19, 2022 18:12
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 19, 2022
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 1fa99d6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 19, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit ae64183 into master May 19, 2022
@mergify mergify bot deleted the revert-20387-optionalMetadata branch May 19, 2022 18:56
wphilipw pushed a commit to wphilipw/aws-cdk that referenced this pull request May 23, 2022
… large manifest" (aws#20421)

aws#20387 tests fail on our merge to v2, likely because CDK v2 uses the new style stack synthesis by default and generates a lot more metadata. Reverting for now to unblock the release.
@comcalvi comcalvi added the effort/small Small work item – less than a day of effort label May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants