Skip to content

feat(core): allow disabling of LogicalID Metadata in case of large manifest#20387

Merged
mergify[bot] merged 10 commits intoaws:masterfrom
comcalvi:optionalMetadata
May 18, 2022
Merged

feat(core): allow disabling of LogicalID Metadata in case of large manifest#20387
mergify[bot] merged 10 commits intoaws:masterfrom
comcalvi:optionalMetadata

Conversation

@comcalvi
Copy link
Copy Markdown
Contributor

@comcalvi comcalvi commented May 17, 2022

Users have encountered an error resulting from the manifest being too large to stringify. This allows users to prevent this metadata from ever being added to the manifest.

Fixes #20211.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@comcalvi comcalvi requested a review from rix0rrr May 17, 2022 22:19
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented May 17, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team May 17, 2022 22:19
@github-actions github-actions bot added bug This issue is a bug. p1 labels May 17, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 17, 2022
@rix0rrr rix0rrr changed the title chore(core): Add an option to disable LogicalID Metadata feat(core): allow disabling of LogicalID Metadata in case of large manifest May 18, 2022
@comcalvi comcalvi added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr-linter/exempt-readme The PR linter will not require README changes labels May 18, 2022
@comcalvi comcalvi added pr/do-not-merge This PR should not be merged at this time. and removed pr/do-not-merge This PR should not be merged at this time. labels May 18, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 18, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 2ab139f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit dc9536a into aws:master May 18, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 18, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Chriscbr added a commit that referenced this pull request May 19, 2022
mergify bot pushed a commit that referenced this pull request May 19, 2022
… large manifest" (#20421)

#20387 tests fail on our merge to v2, likely because CDK v2 uses the new style stack synthesis by default and generates a lot more metadata. Reverting for now to unblock the release.
wphilipw pushed a commit to wphilipw/aws-cdk that referenced this pull request May 23, 2022
…nifest (aws#20387)

Users have encountered an error resulting from the manifest being too large to stringify. This allows users to prevent this metadata from ever being added to the manifest. 

Fixes aws#20211.

----


*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
wphilipw pushed a commit to wphilipw/aws-cdk that referenced this pull request May 23, 2022
… large manifest" (aws#20421)

aws#20387 tests fail on our merge to v2, likely because CDK v2 uses the new style stack synthesis by default and generates a lot more metadata. Reverting for now to unblock the release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This issue is a bug. contribution/core This is a PR that came from AWS. p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Large Apps Fail on writing manifest.json

3 participants