fix(elbv2): unable to add multiple certificates to NLB#19289
Merged
mergify[bot] merged 3 commits intoaws:masterfrom Mar 31, 2022
corymhall:corymhall/elasticloadbalancingv2/fix-nlb-multiple-certs
Merged
fix(elbv2): unable to add multiple certificates to NLB#19289mergify[bot] merged 3 commits intoaws:masterfrom corymhall:corymhall/elasticloadbalancingv2/fix-nlb-multiple-certs
mergify[bot] merged 3 commits intoaws:masterfrom
corymhall:corymhall/elasticloadbalancingv2/fix-nlb-multiple-certs
Conversation
This PR does a couple of things to update the NetworkListener to be on par with ApplicationListener. 1. Add a NetworkListenerCertificate construct that allows you to associate multiple certificates with a listener. 2. Add a `addCertificates` method to `NetworkListener` similar to the same method on the `ApplicationListener`. This is needed because even though the `certificates` property on a `Listener`is an array, it expects only one certificate. To add more than one you have to create an `AWS::ElasticLoadBalancingV2::ListenerCertificate`. This functionality was added to `ApplicationListner` via #13490. fixes #8918, #15328
|
|
rix0rrr
approved these changes
Mar 31, 2022
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
StevePotter
pushed a commit
to StevePotter/aws-cdk
that referenced
this pull request
Apr 27, 2022
This PR does a couple of things to update the NetworkListener to be on par with ApplicationListener. 1. Add a NetworkListenerCertificate construct that allows you to associate multiple certificates with a listener. 2. Add a `addCertificates` method to `NetworkListener` similar to the same method on the `ApplicationListener`. This is needed because even though the `certificates` property on a `Listener`is an array, it expects only one certificate. To add more than one you have to create an `AWS::ElasticLoadBalancingV2::ListenerCertificate`. This functionality was added to `ApplicationListner` via aws#13490. fixes aws#8918, aws#15328 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does a couple of things to update the NetworkListener to be on
par with ApplicationListener.
associate multiple certificates with a listener.
addCertificatesmethod toNetworkListenersimilar to thesame method on the
ApplicationListener.This is needed because even though the
certificatesproperty on aListeneris an array, it expects only one certificate. To add more thanone you have to create an
AWS::ElasticLoadBalancingV2::ListenerCertificate. This functionalitywas added to
ApplicationListnervia #13490.fixes #8918, #15328
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license