fix(elasticloadbalancingv2): upgrade to v1.92.0 drops certificates on ALB if more than 2 certificates exist#13490
Merged
mergify[bot] merged 2 commits intomasterfrom Mar 9, 2021
Merged
Conversation
… ALB if more than 2 certificates exist Support for multiple certificates attached to a single ALB listener was originally implemented by putting all certificates in an array on a single `ListenerCertificate` resource. The docs state that only one certificate may be specified, although multiple certificates do appear to work initially. Initial resource creation of a `ListenerCertificate` with multiple certificates appears to succeed, but subsequent updates to this resource (to either add or remove certificates) yields undefined and undesireable behavior. The fix in #13332 attempted to fix this by creating a new `ListenerCertificate` per certificate, and -- at my direction -- maintained partial backwards compatibility by keeping the original ID for the first `ListenerCertificate` resource. However, this has the effect of triggering an update to the existing resource, which does not appear to work correctly. By forcing a logical ID change for all `ListenerCertificate` resources, we can force all existing resources to be deleted, and new resources created. This avoids doing any updates on any `ListenerCertificate` resources with an array of certificates, which appears to side-step the undefined behavior. fixes #13437
|
|
nija-at
approved these changes
Mar 9, 2021
Contributor
nija-at
left a comment
There was a problem hiding this comment.
Looks like the same issue I had a month ago but for a different resource - 96cbe32#diff-d415373a5da24bc939a806d1dbd72f953000f19b3ae72978c65fa851d310e0d6
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This was referenced Mar 12, 2021
Merged
This was referenced Mar 14, 2021
Merged
Merged
Merged
Closed
Closed
mergify bot
pushed a commit
that referenced
this pull request
Mar 31, 2022
This PR does a couple of things to update the NetworkListener to be on par with ApplicationListener. 1. Add a NetworkListenerCertificate construct that allows you to associate multiple certificates with a listener. 2. Add a `addCertificates` method to `NetworkListener` similar to the same method on the `ApplicationListener`. This is needed because even though the `certificates` property on a `Listener`is an array, it expects only one certificate. To add more than one you have to create an `AWS::ElasticLoadBalancingV2::ListenerCertificate`. This functionality was added to `ApplicationListner` via #13490. fixes #8918, #15328 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
StevePotter
pushed a commit
to StevePotter/aws-cdk
that referenced
this pull request
Apr 27, 2022
This PR does a couple of things to update the NetworkListener to be on par with ApplicationListener. 1. Add a NetworkListenerCertificate construct that allows you to associate multiple certificates with a listener. 2. Add a `addCertificates` method to `NetworkListener` similar to the same method on the `ApplicationListener`. This is needed because even though the `certificates` property on a `Listener`is an array, it expects only one certificate. To add more than one you have to create an `AWS::ElasticLoadBalancingV2::ListenerCertificate`. This functionality was added to `ApplicationListner` via aws#13490. fixes aws#8918, aws#15328 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for multiple certificates attached to a single ALB listener was
originally implemented by putting all certificates in an array on a single
ListenerCertificateresource. The docs state that only one certificate may bespecified, although multiple certificates do appear to work initially. Initial
resource creation of a
ListenerCertificatewith multiple certificates appearsto succeed, but subsequent updates to this resource (to either add or remove
certificates) yields undefined and undesireable behavior.
The fix in #13332 attempted to fix this by creating a new
ListenerCertificateper certificate, and -- at my direction -- maintained partial backwards
compatibility by keeping the original ID for the first
ListenerCertificateresource. However, this has the effect of triggering an update to the existing
resource, which does not appear to work correctly.
By forcing a logical ID change for all
ListenerCertificateresources, we canforce all existing resources to be deleted, and new resources created. This
avoids doing any updates on any
ListenerCertificateresources with an arrayof certificates, which appears to side-step the undefined behavior.
fixes #13437
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license