chore(apigateway): migrated tests to assertions#18562
Conversation
|
|
| '', | ||
| [ | ||
| stringLike('*#set($includeQueryString = true)*'), | ||
| Match.stringLikeRegexp('#set\\(\\$includeQueryString = true\\)'), |
| // THEN | ||
| // should have an api key with no props defined. | ||
| expect(stack).toHaveResource('AWS::ApiGateway::ApiKey', undefined, ResourcePart.CompleteDefinition); | ||
| Template.fromStack(stack).hasResource('AWS::ApiGateway::ApiKey', Match.anyValue()); |
There was a problem hiding this comment.
I feel like this isn't exactly "should have an api key with no props defined". We should be able to assert this (reference PR):
Template.fromStack(stack).hasResourceProperties('AWS::ApiGateway::ApiKey', Match.absent());There was a problem hiding this comment.
Ah, makes sense. I'll fix it.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
flagging as DNM for just the one comment that I feel breaks fidelity. up to you though. |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license