fix(assertions): hasResourceProperties is incompatible with Match.not and Match.absent#16678
Merged
mergify[bot] merged 12 commits intoaws:masterfrom Oct 6, 2021
kaizencc:assertions-bug-fix
Merged
fix(assertions): hasResourceProperties is incompatible with Match.not and Match.absent#16678mergify[bot] merged 12 commits intoaws:masterfrom kaizencc:assertions-bug-fix
hasResourceProperties is incompatible with Match.not and Match.absent#16678mergify[bot] merged 12 commits intoaws:masterfrom
kaizencc:assertions-bug-fix
Conversation
|
|
kaizencc
commented
Sep 27, 2021
nija-at
suggested changes
Sep 29, 2021
924c117 to
ebfd5f2
Compare
kaizencc
commented
Oct 5, 2021
nija-at
reviewed
Oct 6, 2021
hasResourceProperties is incompatible with Match.not and Match.absentPropertyhasResourceProperties is incompatible with Match.not and Match.absent
nija-at
approved these changes
Oct 6, 2021
Contributor
nija-at
left a comment
There was a problem hiding this comment.
PR descriptions get converted into commit messages, so it will be a good idea to update this from what you have now.
Commit messages should usually contain what is being changed and why.
One minor comment below. Approved with 'do-not-merge' label.
Contributor
Author
|
@Mergifyio refresh |
Contributor
|
Command
|
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
njlynch
pushed a commit
that referenced
this pull request
Oct 11, 2021
…not` and `Match.absent` (#16678) Fixes #16626. This PR modifies `hasResourceProperties()` so that it accounts for the special case where `Properties` does not exist on the template. The following assertions previously behaved incorrectly when `Properties` were not in the template and are now fixed: ```ts template.fromStack(stack); // some template with no `Properties`. // assert that `Properties` does not exist in the template. Returns true. template.hasResourceProperties('Foo::Bar', Match.absent()); // assert that `baz` is not a `Property` of 'Foo::Bar'. Returns true. template.hasResourceProperties('Foo::Bar', { baz: Match.absent(), }; // assert that `baz` does not have a value of `qux` in the `Properties` object. Returns true. template.hasResourceProperties('Foo::Bar', Match.not({baz: 'qux'}); ``` It also moves `AbsentMatch` into the `private` folder so that it can be exposed internally as a special case for `hasResourceProperties()`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…not` and `Match.absent` (aws#16678) Fixes aws#16626. This PR modifies `hasResourceProperties()` so that it accounts for the special case where `Properties` does not exist on the template. The following assertions previously behaved incorrectly when `Properties` were not in the template and are now fixed: ```ts template.fromStack(stack); // some template with no `Properties`. // assert that `Properties` does not exist in the template. Returns true. template.hasResourceProperties('Foo::Bar', Match.absent()); // assert that `baz` is not a `Property` of 'Foo::Bar'. Returns true. template.hasResourceProperties('Foo::Bar', { baz: Match.absent(), }; // assert that `baz` does not have a value of `qux` in the `Properties` object. Returns true. template.hasResourceProperties('Foo::Bar', Match.not({baz: 'qux'}); ``` It also moves `AbsentMatch` into the `private` folder so that it can be exposed internally as a special case for `hasResourceProperties()`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16626.
This PR modifies
hasResourceProperties()so that it accounts for the special case wherePropertiesdoes not exist on the template. The following assertions previously behaved incorrectly whenPropertieswere not in the template and are now fixed:It also moves
AbsentMatchinto theprivatefolder so that it can be exposed internally as a special case forhasResourceProperties().By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license