fix(core): overriding of Stack.addFileAsset() no longer has effect#18116
Merged
mergify[bot] merged 3 commits intomasterfrom Dec 21, 2021
Merged
fix(core): overriding of Stack.addFileAsset() no longer has effect#18116mergify[bot] merged 3 commits intomasterfrom
Stack.addFileAsset() no longer has effect#18116mergify[bot] merged 3 commits intomasterfrom
Conversation
It used to be that you could override `Stack.addFileAsset()` to add different behavior to handle the assets. Later on, we introduced the concept of `StackSynthesizers` to handle this concept, with a backwards compatibility mechanism. In #17328, the backwards compatibility mechanism was broken. Restore it.
|
|
Contributor
|
@rix0rrr will this cause deprecation warnings for CDK users? |
Contributor
Author
Sigh. Yes. Yes it will. |
skinny85
approved these changes
Dec 21, 2021
Contributor
skinny85
left a comment
There was a problem hiding this comment.
Thanks for the quick reaction to this one Rico! 👍
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…ws#18116) It used to be that you could override `Stack.addFileAsset()` to add different behavior to handle the assets. Later on, we introduced the concept of `StackSynthesizers` to handle this concept, with a backwards compatibility mechanism. In aws#17328, the backwards compatibility mechanism was broken. Restore it. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It used to be that you could override
Stack.addFileAsset()to adddifferent behavior to handle the assets. Later on, we introduced
the concept of
StackSynthesizersto handle this concept, with abackwards compatibility mechanism.
In #17328, the backwards compatibility mechanism was broken. Restore it.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license