feat: warn users when deprecated elements are used#17328
Merged
mergify[bot] merged 97 commits intomasterfrom Nov 16, 2021
Merged
feat: warn users when deprecated elements are used#17328mergify[bot] merged 97 commits intomasterfrom
mergify[bot] merged 97 commits intomasterfrom
Conversation
added 22 commits
November 3, 2021 14:08
|
|
b053c7a to
52dd171
Compare
added 3 commits
November 4, 2021 11:17
1a2e1f5 to
d5b58e0
Compare
nija-at
commented
Nov 10, 2021
added 2 commits
November 16, 2021 14:47
njlynch
approved these changes
Nov 16, 2021
added 6 commits
November 16, 2021 16:35
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
rix0rrr
added a commit
that referenced
this pull request
Dec 21, 2021
It used to be that you could override `Stack.addFileAsset()` to add different behavior to handle the assets. Later on, we introduced the concept of `StackSynthesizers` to handle this concept, with a backwards compatibility mechanism. In #17328, the backwards compatibility mechanism was broken. Restore it.
mergify bot
pushed a commit
that referenced
this pull request
Dec 21, 2021
…18116) It used to be that you could override `Stack.addFileAsset()` to add different behavior to handle the assets. Later on, we introduced the concept of `StackSynthesizers` to handle this concept, with a backwards compatibility mechanism. In #17328, the backwards compatibility mechanism was broken. Restore it. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
Turn on notifications during `cdk synth` and `cdk deploy` when users are using deprecated elements. As part of this, the repo will need to remove all usages of deprecated symbols used within its implementation. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…ws#18116) It used to be that you could override `Stack.addFileAsset()` to add different behavior to handle the assets. Later on, we introduced the concept of `StackSynthesizers` to handle this concept, with a backwards compatibility mechanism. In aws#17328, the backwards compatibility mechanism was broken. Restore it. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turn on notifications during
cdk synthandcdk deploywhenusers are using deprecated elements.
As part of this, the repo will need to remove all usages of
deprecated symbols used within its implementation.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license