Skip to content

chore: integ failures due to unbound variable on FRAMEWORK_VERSION#17308

Merged
mergify[bot] merged 3 commits intomasterfrom
epolon/fix-framework-version-default
Nov 3, 2021
Merged

chore: integ failures due to unbound variable on FRAMEWORK_VERSION#17308
mergify[bot] merged 3 commits intomasterfrom
epolon/fix-framework-version-default

Conversation

@iliapolo
Copy link
Copy Markdown
Contributor

@iliapolo iliapolo commented Nov 3, 2021

Follow up fix for #17276

export CANDIDATE_VERSION=1.131.0-rc.0
--
690 | + CANDIDATE_VERSION=1.131.0-rc.0
691 | /codebuild/output/src644443490/src/package/test/integ/run-against-dist: line 29: FRAMEWORK_VERSION: unbound variable
692 | ++ run_traps

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Nov 3, 2021

@iliapolo iliapolo changed the title chore: set FRAMEWORK_VERSION default to avoid unbound error chore: integ failures due to unbound variable on FRAMEWORK_VERSION Nov 3, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 3, 2021
@iliapolo iliapolo requested a review from a team November 3, 2021 15:57
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 3, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 33e48bc
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit e05bd01 into master Nov 3, 2021
@mergify mergify bot deleted the epolon/fix-framework-version-default branch November 3, 2021 18:20
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 3, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…ws#17308)

Follow up fix for aws#17276

```console
export CANDIDATE_VERSION=1.131.0-rc.0
--
690 | + CANDIDATE_VERSION=1.131.0-rc.0
691 | /codebuild/output/src644443490/src/package/test/integ/run-against-dist: line 29: FRAMEWORK_VERSION: unbound variable
692 | ++ run_traps
```

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants