chore(cli): integ tests install matching framework version#17276
Merged
mergify[bot] merged 2 commits intomasterfrom Nov 3, 2021
Merged
chore(cli): integ tests install matching framework version#17276mergify[bot] merged 2 commits intomasterfrom
mergify[bot] merged 2 commits intomasterfrom
Conversation
|
|
If the regression tests are running in straight up integ test mode, and not regression mode, they don't run with a `FRAMEWORK_VERSION` set. The end result is that they install the version `*` of every library, which always resolves to the v1 version. If we're running in straight-up integ test mode, copy the framework version from the CLI.
73075da to
f15739f
Compare
njlynch
approved these changes
Nov 2, 2021
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify bot
pushed a commit
that referenced
this pull request
Nov 3, 2021
…17308) Follow up fix for #17276 ```console export CANDIDATE_VERSION=1.131.0-rc.0 -- 690 | + CANDIDATE_VERSION=1.131.0-rc.0 691 | /codebuild/output/src644443490/src/package/test/integ/run-against-dist: line 29: FRAMEWORK_VERSION: unbound variable 692 | ++ run_traps ``` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
If the regression tests are running in straight up integ test mode, and not regression mode, they don't run with a `FRAMEWORK_VERSION` set. The end result is that they install the version `*` of every library, which always resolves to the v1 version. If we're running in straight-up integ test mode, copy the framework version from the CLI. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…ws#17308) Follow up fix for aws#17276 ```console export CANDIDATE_VERSION=1.131.0-rc.0 -- 690 | + CANDIDATE_VERSION=1.131.0-rc.0 691 | /codebuild/output/src644443490/src/package/test/integ/run-against-dist: line 29: FRAMEWORK_VERSION: unbound variable 692 | ++ run_traps ``` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the regression tests are running in straight up integ test mode,
and not regression mode, they don't run with a
FRAMEWORK_VERSIONset.The end result is that they install the version
*of every library,which always resolves to the v1 version.
If we're running in straight-up integ test mode, copy the framework
version from the CLI.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license