chore(CDK V2 canaries): allow canary tests to run with a specific aws-cdk version#17285
Merged
mergify[bot] merged 7 commits intoaws:masterfrom Nov 3, 2021
Merged
chore(CDK V2 canaries): allow canary tests to run with a specific aws-cdk version#17285mergify[bot] merged 7 commits intoaws:masterfrom
mergify[bot] merged 7 commits intoaws:masterfrom
Conversation
|
|
Contributor
|
@rix0rrr beat you to it by about 8 hours, I think -- #17276. Let's sync up about this and https://github.com/cdklabs/cdk-ops/pull/1769 and figure out the best path forward. |
rix0rrr
approved these changes
Nov 3, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…-cdk version (aws#17285) If an environment variable, `$RELEASE_TAG` is defined, it will be appended to the end of the `npm install aws-cdk@` command. This will allow us to run canaries that test against v2 by specifying `RELEASE_TAG=next` in the environment variables. If `$RELEASE_TAG` is not defined, `npm install aws-cdk@latest` will be used. This PR also includes a comment in `release-notes.ts` that the v2 publishing verification canary is dependent on the format of the release notes. part of aws#16593, see https://github.com/cdklabs/cdk-ops/pull/1769 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an environment variable,
$RELEASE_TAGis defined, it will be appended to the end of thenpm install aws-cdk@command. This will allow us to run canaries that test against v2 by specifyingRELEASE_TAG=nextin the environment variables. If$RELEASE_TAGis not defined,npm install aws-cdk@latestwill be used.This PR also includes a comment in
release-notes.tsthat the v2 publishing verification canary is dependent on the format of the release notes.part of #16593, see https://github.com/cdklabs/cdk-ops/pull/1769
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license