Skip to content

revert(cli): 'deploy' and 'diff' silently does nothing when given unknown stack name#16125

Merged
mergify[bot] merged 2 commits intomasterfrom
revert-16073-cli-check
Aug 19, 2021
Merged

revert(cli): 'deploy' and 'diff' silently does nothing when given unknown stack name#16125
mergify[bot] merged 2 commits intomasterfrom
revert-16073-cli-check

Conversation

@kaizencc
Copy link
Copy Markdown
Contributor

@kaizencc kaizencc commented Aug 18, 2021 •
edited by BenChaimberg
Loading

Broke integration tests when synthing without providing a stack name

reverts #16073

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Aug 18, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 18, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 18, 2021

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@BenChaimberg BenChaimberg changed the title Revert "fix(cli): 'deploy' and 'diff' silently does nothing when given unknown stack name" revert(cli): 'deploy' and 'diff' silently does nothing when given unknown stack name Aug 18, 2021
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Aug 19, 2021

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: b93a2fd
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit f2d77d3 into master Aug 19, 2021
@mergify mergify bot deleted the revert-16073-cli-check branch August 19, 2021 00:17
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 19, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

smguggen pushed a commit to smguggen/aws-cdk that referenced this pull request Aug 24, 2021
@kaizencc @smguggen
revert(cli): 'deploy' and 'diff' silently does nothing when given unk…
626b646 
…nown stack name (aws#16125)

Broke integration tests when `synth`ing without providing a stack name

reverts aws#16073
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
@kaizencc @hollanddd
revert(cli): 'deploy' and 'diff' silently does nothing when given unk…
1559fbc 
…nown stack name (aws#16125)

Broke integration tests when `synth`ing without providing a stack name

reverts aws#16073
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Sep 6, 2021
@kaizencc @TikiTDO
revert(cli): 'deploy' and 'diff' silently does nothing when given unk…
e4eb005 
…nown stack name (aws#16125)

Broke integration tests when `synth`ing without providing a stack name

reverts aws#16073
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this pull request Sep 7, 2021
@kaizencc @david-doyle-as24
revert(cli): 'deploy' and 'diff' silently does nothing when given unk…
7be414f 
…nown stack name (aws#16125)

Broke integration tests when `synth`ing without providing a stack name

reverts aws#16073
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@BenChaimberg BenChaimberg BenChaimberg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kaizencc @aws-cdk-automation @BenChaimberg