fix(cli): 'deploy' and 'diff' silently does nothing when given unknown stack name by kaizencc · Pull Request #16073 · aws/aws-cdk

kaizencc · 2021-08-16T21:32:00Z

Currently, cdk deploy and cdk diff on stacks that do not exist return no output on the command line. This PR introduces a descriptive error message for those cases so it is easier to understand what happened.

Leaving the idea of fuzzy matching for stack name suggestions to a (potential) future PR, I can open a new issue for that if this one goes through.

For the linter, I'm not sure if anything of value can be added to the readme so I'm wondering if this would be a candidate for exemption.

closes #15866 while adding the same idea to diff as well as deploy.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

… 'cdk deploy'

gitpod-io · 2021-08-16T21:32:02Z

rix0rrr

Thanks! Provisional approval, if you do a small refactor.

Also, about the subject line of the PR: this will go into the CHANGELOG, so think about how a customer reading the CHANGELOG will think about this change.

I would classify it as a bugfix, and if it's a bugfix we generally describe the issue that we fixed. So I would name it something like:

fix(cli): silently does nothing when given unknown stack name

Or something to that effect.

rix0rrr · 2021-08-18T07:49:45Z

packages/aws-cdk/lib/cdk-toolkit.ts

   */
-  private async validateStacks(stacks: StackCollection) {
+  private async validateStacks(stacks: StackCollection, stackNames: string[]) {
+    if (stacks.stackCount == 0) {


I agree with this check, but I think it should not be part of this function. Validating that there are stacks is not what this function is doing (it's checking stack metadata).

How about adding a new function?

function validateStacksSelected(stacks: StackCollection, stackNames: string[]);

Or something?

aws-cdk-automation · 2021-08-18T16:33:19Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
Commit ID: 76a219a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2021-08-18T20:09:34Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

…n unknown stack name (#16073)" This reverts commit f35b032.

…nown stack name (#16125) Broke integration tests when `synth`ing without providing a stack name reverts #16073

…n stack name (aws#16073) Currently, `cdk deploy` and `cdk diff` on stacks that do not exist return no output on the command line. This PR introduces a descriptive error message for those cases so it is easier to understand what happened. Leaving the idea of fuzzy matching for stack name suggestions to a (potential) future PR, I can open a new issue for that if this one goes through. For the linter, I'm not sure if anything of value can be added to the readme so I'm wondering if this would be a candidate for exemption. closes aws#15866 while adding the same idea to `diff` as well as `deploy`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

…nown stack name (aws#16125) Broke integration tests when `synth`ing without providing a stack name reverts aws#16073

…n stack name (aws#16073) Currently, `cdk deploy` and `cdk diff` on stacks that do not exist return no output on the command line. This PR introduces a descriptive error message for those cases so it is easier to understand what happened. Leaving the idea of fuzzy matching for stack name suggestions to a (potential) future PR, I can open a new issue for that if this one goes through. For the linter, I'm not sure if anything of value can be added to the readme so I'm wondering if this would be a candidate for exemption. closes aws#15866 while adding the same idea to `diff` as well as `deploy`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

…nown stack name (aws#16125) Broke integration tests when `synth`ing without providing a stack name reverts aws#16073

…n stack name (aws#16073) Currently, `cdk deploy` and `cdk diff` on stacks that do not exist return no output on the command line. This PR introduces a descriptive error message for those cases so it is easier to understand what happened. Leaving the idea of fuzzy matching for stack name suggestions to a (potential) future PR, I can open a new issue for that if this one goes through. For the linter, I'm not sure if anything of value can be added to the readme so I'm wondering if this would be a candidate for exemption. closes aws#15866 while adding the same idea to `diff` as well as `deploy`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

…nown stack name (aws#16125) Broke integration tests when `synth`ing without providing a stack name reverts aws#16073

…n stack name (aws#16073) Currently, `cdk deploy` and `cdk diff` on stacks that do not exist return no output on the command line. This PR introduces a descriptive error message for those cases so it is easier to understand what happened. Leaving the idea of fuzzy matching for stack name suggestions to a (potential) future PR, I can open a new issue for that if this one goes through. For the linter, I'm not sure if anything of value can be added to the readme so I'm wondering if this would be a candidate for exemption. closes aws#15866 while adding the same idea to `diff` as well as `deploy`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

…nown stack name (aws#16125) Broke integration tests when `synth`ing without providing a stack name reverts aws#16073

kaizencc added 2 commits August 16, 2021 17:13

throw descriptive error when no stacks match input for 'cdk diff' and…

a30fd3b

… 'cdk deploy'

fix linter

d379e8e

mergify bot added the contribution/core This is a PR that came from AWS. label Aug 16, 2021

kaizencc requested a review from rix0rrr August 16, 2021 21:33

kaizencc self-assigned this Aug 16, 2021

rix0rrr added the pr/do-not-merge This PR should not be merged at this time. label Aug 18, 2021

rix0rrr approved these changes Aug 18, 2021

View reviewed changes

kaizencc changed the title ~~feat(cli): send error message when attempting to deploy/diff on stacks that do not exist~~ fix(cli): 'deploy' and 'diff' silently does nothing when given unknown stack name Aug 18, 2021

Merge branch 'master' into cli-check

76a219a

kaizencc removed the pr/do-not-merge This PR should not be merged at this time. label Aug 18, 2021

mergify bot merged commit f35b032 into aws:master Aug 18, 2021

kaizencc added a commit that referenced this pull request Aug 18, 2021

Revert "fix(cli): 'deploy' and 'diff' silently does nothing when give…

e41ec51

…n unknown stack name (#16073)" This reverts commit f35b032.

kaizencc mentioned this pull request Aug 18, 2021

revert(cli): 'deploy' and 'diff' silently does nothing when given unknown stack name #16125

Merged

mergify bot pushed a commit that referenced this pull request Aug 19, 2021

revert(cli): 'deploy' and 'diff' silently does nothing when given unk…

f2d77d3

…nown stack name (#16125) Broke integration tests when `synth`ing without providing a stack name reverts #16073

smguggen pushed a commit to smguggen/aws-cdk that referenced this pull request Aug 24, 2021

revert(cli): 'deploy' and 'diff' silently does nothing when given unk…

626b646

…nown stack name (aws#16125) Broke integration tests when `synth`ing without providing a stack name reverts aws#16073

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Sep 6, 2021

revert(cli): 'deploy' and 'diff' silently does nothing when given unk…

e4eb005

…nown stack name (aws#16125) Broke integration tests when `synth`ing without providing a stack name reverts aws#16073

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(cli): 'deploy' and 'diff' silently does nothing when given unknown stack name#16073

fix(cli): 'deploy' and 'diff' silently does nothing when given unknown stack name#16073
mergify[bot] merged 3 commits intoaws:masterfrom
kaizencc:cli-check

kaizencc commented Aug 16, 2021 •

edited

Loading

Uh oh!

gitpod-io bot commented Aug 16, 2021

Uh oh!

rix0rrr left a comment

Uh oh!

rix0rrr Aug 18, 2021

Uh oh!

aws-cdk-automation commented Aug 18, 2021

Uh oh!

mergify bot commented Aug 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

kaizencc commented Aug 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gitpod-io bot commented Aug 16, 2021

Uh oh!

rix0rrr left a comment

Choose a reason for hiding this comment

Uh oh!

rix0rrr Aug 18, 2021

Choose a reason for hiding this comment

Uh oh!

aws-cdk-automation commented Aug 18, 2021

AWS CodeBuild CI Report

Uh oh!

mergify bot commented Aug 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kaizencc commented Aug 16, 2021 •

edited

Loading